Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-6772

Advanced Upload assignment type - update grade and comment when file is uploaded

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.7, 1.9.8, 2.0
    • Fix Version/s: FRONTEND
    • Component/s: Assignment (2.2)
    • Labels:
    • Environment:
      WinXP, Apache, MySql
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      When teacher is grading an assignment with the pop-up window (i.e., NOT quick-grade), changes to the grade and comment are lost if the teacher clicks on "upload this file" instead of "save changes". Ideally, the grade and comment should also be saved as part of the file upload process, and s specified file should be uploaded as part of the "save changes" routine.

      If there are no changes to the fields, then there is no harm, but my teachers report that they often set teh grade, write a comment, and attach a file all at once, and then loose either the grade and comment or the file.

      Couldn't one "save" button take care of both operations?

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            I agree this is a problem, unfortunately the solution would require major rewrite of the underlying code, there is no way to do it properly before 1.7 Beta
            The current upload function is quite hacky, I had only 3 days to write+test it.

            This should be definitely solved in 1.8.

            Show
            skodak Petr Skoda added a comment - I agree this is a problem, unfortunately the solution would require major rewrite of the underlying code, there is no way to do it properly before 1.7 Beta The current upload function is quite hacky, I had only 3 days to write+test it. This should be definitely solved in 1.8.
            Hide
            skodak Petr Skoda added a comment -

            Maybe we could add some comment next to "Response files:" to instruct teachers to upload first and then start typing in the textbox, what do you think?

            Show
            skodak Petr Skoda added a comment - Maybe we could add some comment next to "Response files:" to instruct teachers to upload first and then start typing in the textbox, what do you think?
            Hide
            bgray@sstx.org Brian Gray added a comment -

            That would probably be helpful. It may also help to put the "grade and comment" part and the "upload" part in separate boxes within that window. Any visual cue that they must be separate activities will help.

            bkg

            Show
            bgray@sstx.org Brian Gray added a comment - That would probably be helpful. It may also help to put the "grade and comment" part and the "upload" part in separate boxes within that window. Any visual cue that they must be separate activities will help. bkg
            Hide
            skodak Petr Skoda added a comment -

            Thanks for the feedback and ideas, I will think more about it and ask MD tomorrow.

            Show
            skodak Petr Skoda added a comment - Thanks for the feedback and ideas, I will think more about it and ask MD tomorrow.
            Hide
            adamann2 Ann Adamcik added a comment - - edited

            Interim patch to make clear to users that response files should be uploaded separately from entering grade and notes.

            The real problem is that there are 2 separate forms on the feedback dialog that are processed separately. The right solution is probably to overload the display_submission() and process_feedback() methods to display and process an integrated form.

            This should really be a bug rather than an improvement request.

            Show
            adamann2 Ann Adamcik added a comment - - edited Interim patch to make clear to users that response files should be uploaded separately from entering grade and notes. The real problem is that there are 2 separate forms on the feedback dialog that are processed separately. The right solution is probably to overload the display_submission() and process_feedback() methods to display and process an integrated form. This should really be a bug rather than an improvement request.
            Hide
            hrynkiw Donna Hrynkiw added a comment -

            This bug is still biting us in v1.9.4+.

            Donna Hrynkiw
            Kwantlen Polytechnic

            Show
            hrynkiw Donna Hrynkiw added a comment - This bug is still biting us in v1.9.4+. Donna Hrynkiw Kwantlen Polytechnic
            Hide
            cttxg Teresa Gibbison added a comment -

            We still have this issue with 1.9.5+
            Can someone please re-visit and put a fix version on this?
            Cheers
            Teresa Gibbison

            Show
            cttxg Teresa Gibbison added a comment - We still have this issue with 1.9.5+ Can someone please re-visit and put a fix version on this? Cheers Teresa Gibbison
            Hide
            cttxg Teresa Gibbison added a comment -

            Can I bump this issue please for 2010? Anyone able to alter the affected version (currently this is still happening with 1.9.8+)
            Cheers
            Teresa

            Show
            cttxg Teresa Gibbison added a comment - Can I bump this issue please for 2010? Anyone able to alter the affected version (currently this is still happening with 1.9.8+) Cheers Teresa
            Hide
            peterisr Peteris Rudzajs added a comment -

            Voting for this!

            Show
            peterisr Peteris Rudzajs added a comment - Voting for this!
            Hide
            tsala Helen Foster added a comment -

            Thanks for everyone's comments and apologies for not updating the issue before now. Unfortunately there's not enough time to fix this in 2.0, but increasing the priority and setting a fix version of 2.1.

            Show
            tsala Helen Foster added a comment - Thanks for everyone's comments and apologies for not updating the issue before now. Unfortunately there's not enough time to fix this in 2.0, but increasing the priority and setting a fix version of 2.1.
            Hide
            tsala Helen Foster added a comment -

            Increasing priority again.

            Show
            tsala Helen Foster added a comment - Increasing priority again.
            Hide
            chuang Wen Hao Chuang added a comment -

            Any update on this ticket? Just curious...

            Show
            chuang Wen Hao Chuang added a comment - Any update on this ticket? Just curious...
            Hide
            tommylister Tommy added a comment -

            (2.3) We are running into the issue where faculty re-update the comment field for an assignment only to have the original feedback deleted. This was not an issue in Moodle 1.9, faculty would use the online text assignment as a means for a journal-type dialog for each student.

            Any news on a fix for this?

            Show
            tommylister Tommy added a comment - (2.3) We are running into the issue where faculty re-update the comment field for an assignment only to have the original feedback deleted. This was not an issue in Moodle 1.9, faculty would use the online text assignment as a means for a journal-type dialog for each student. Any news on a fix for this?

              People

              • Votes:
                25 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated: