Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67735

Remove Bootstrap 2 and Bootstrap 4 alpha compatibility files

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test .tag to .badge changes
      1. Create a few courses or use existing ones and enrol yourself in the courses
      2. Hide one of the course using the course settings page
      3. Navigate to your dashboard
      4. Verify you see the ‘Hidden from students’ badge (It is okay if the font color is now black which is the Bootstrap default

      Test css class changes for spacing (p-l-x) etc
      1. On your dashboard switch to the summary view
      2. Inspect div that wraps the div with class progress
      3. Verify it has a padding top of 1 rem.

      4. Navigate to Site Administration -> Users -> Privacy and policies -> Plugin privacy registry
      5. Open one of the Sections
      6. Verify the spacing before the items in the section has not changed

       

      Test css class changes for .row-fluid to .row
      1. As admin open your messages using the speech bubble icon in the navbar
      2. On the message drawer click the ‘See all’ link
      3. This should open the full page message UI
      4.* Verify* the message UI fits its container
      5. Verify the UI has not changed

      Show
      Test .tag to .badge changes 1. Create a few courses or use existing ones and enrol yourself in the courses 2. Hide one of the course using the course settings page 3. Navigate to your dashboard 4. Verify you see the ‘Hidden from students’ badge (It is okay if the font color is now black which is the Bootstrap default Test css class changes for spacing (p-l-x) etc 1. On your dashboard switch to the summary view 2. Inspect div that wraps the div with class progress 3. Verify it has a padding top of 1 rem. 4. Navigate to Site Administration -> Users -> Privacy and policies -> Plugin privacy registry 5. Open one of the Sections 6. Verify the spacing before the items in the section has not changed   Test css class changes for .row-fluid to .row 1. As admin open your messages using the speech bubble icon in the navbar 2. On the message drawer click the ‘See all’ link 3. This should open the full page message UI 4.* Verify* the message UI fits its container 5. Verify the UI has not changed
    • Affected Branches:
      MOODLE_310_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-67735-master

      Description

      To reduce that amount of CSS shipped with the Boost theme we should start looking at our core CSS and cleanup unused CSS

      Since the bootstrap base theme is no longer supported and the bootstrap css is from upstream bootstrap version 4.3.1 it is time to remove files
      theme/boost/scss/moodle/bs2-compat.scss and theme/boost/scss/moodle/bs4alphacompat.scss

      Of course we need to check carefully if there are no renderers or templates still using legacy Bootstrap Classes.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              basbrands Bas Brands
              Peer reviewer:
              Amaia Anabitarte
              Integrator:
              Andrew Nicols
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 2 hours, 2 minutes
                  3d 2h 2m