[MDL-67767] Incorrect param type for tool_mobile/forcedurlscheme setting - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.4, 3.8.1
Fix Version/s: 3.7.5, 3.8.2
Component/s: Other
Labels:
- ci
- triaged

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
git://github.com/dpalou/moodle.git
Pull Master Branch:
~~MDL-67767~~-master
Pull Master Diff URL:
https://github.com/dpalou/moodle/compare/d7374522ed...MDL-67767-master
Testing Instructions:
Hide

Test saving the setting

Log in as admin.

Go to Site administration > Mobile app > Mobile authentication.

In the field forcedurlscheme, enter the value "mmlearn-moodle" and save changes. Check that no error is displayed and the value is stored.

Test launch.php

Log in as admin.

Go to "Site administration > Mobile app > Mobile settings" and enable "web services for mobile devices".

Go to "Site administration > Mobile app > Mobile authentication" and set "Type of login" to "Via a browser window (for SSO plugins)".

Log out.

Now open the following URL in a new tab. Please notice you need to replace the SITEURL with your site URL:

http://SITEURL/admin/tool/mobile/launch.php?service=moodle_mobile_app&passport=a&urlscheme=my-0scheme.a%2Bb

Check that you're redirected to the login screen.

Now open the following URL. Please notice you need to replace the SITEURL with your site URL:

http://SITEURL/admin/tool/mobile/launch.php?service=moodle_mobile_app&passport=a&urlscheme=0scheme

Check that you see an error saying: Invalid parameter: the value of urlscheme isn't valid...

Now open the following URL. Please notice you need to replace the SITEURL with your site URL:

http://SITEURL/admin/tool/mobile/launch.php?service=moodle_mobile_app&passport=a&urlscheme=my_scheme

Check that you see an error saying: Invalid parameter: the value of urlscheme isn't valid...
Show
Test saving the setting Log in as admin. Go to Site administration > Mobile app > Mobile authentication. In the field forcedurlscheme , enter the value "mmlearn-moodle" and save changes. Check that no error is displayed and the value is stored. Test launch.php Log in as admin. Go to "Site administration > Mobile app > Mobile settings" and enable "web services for mobile devices". Go to "Site administration > Mobile app > Mobile authentication" and set "Type of login" to "Via a browser window (for SSO plugins)". Log out. Now open the following URL in a new tab. Please notice you need to replace the SITEURL with your site URL: http://SITEURL/admin/tool/mobile/launch.php?service=moodle_mobile_app&passport=a&urlscheme=my-0scheme.a%2Bb Check that you're redirected to the login screen. Now open the following URL. Please notice you need to replace the SITEURL with your site URL: http://SITEURL/admin/tool/mobile/launch.php?service=moodle_mobile_app&passport=a&urlscheme=0scheme Check that you see an error saying: Invalid parameter: the value of urlscheme isn't valid... Now open the following URL. Please notice you need to replace the SITEURL with your site URL: http://SITEURL/admin/tool/mobile/launch.php?service=moodle_mobile_app&passport=a&urlscheme=my_scheme Check that you see an error saying: Invalid parameter: the value of urlscheme isn't valid...

Description

According rfc2396 custom URL schemes should start with a letter (upper or lower case), and can contain letters (upper and/or lower case), numbers, and the following characters: "+", "-" and "."

Right now, we are forcing PARAM_ALPHANUM for the setting so schemes like: mmlearn-moodle are not properly working.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-67767.png
276 kB
05/Mar/20 1:24 PM

Issue Links

has been marked as being related by

MDL-68120 Extend PARAM to add some extra options to expand dynamically the regular expressions

Open

Activity

People

Assignee:: Dani Palou

Reporter:: Juan Leyva

Peer reviewer:: Juan Leyva

Integrator:: Sara Arjona (@sarjona)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Dani Palou, Juan Leyva, Sara Arjona (@sarjona)

Component watchers:: Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 22/Jan/20 5:21 PM

Updated:: 06/Mar/20 4:11 PM

Resolved:: 06/Mar/20 12:58 AM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Remaining:

Logged:

1h 35m