Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67768

Some common dirs missing in core_component::$ignoreddirs

    XMLWordPrintable

Details

    • MOODLE_38_STABLE
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • MDL-67768-master-componentdirs
    • Hide

      Requires access to the Moodle source code.

      1. Turn developer debugging on visible
      2. Create directories webservice/amd/ and webservice/lang/
      3. Log in as admin
      4. Visit the Administration > Notifications page
      5. TEST Check that no upgrade is triggered and no messages about missing version.php are shown
      Show
      Requires access to the Moodle source code. Turn developer debugging on visible Create directories webservice/amd/ and webservice/lang/ Log in as admin Visit the Administration > Notifications page TEST Check that no upgrade is triggered and no messages about missing version.php are shown

    Description

      The core_component::$ignoreddirs lists all directories that are reserved and cannot be used as valid plugin names. At the moment, it does not contain amd and lang.

      This is a problem because we have webservice defined as both a core subsystem as well as a plugin type (for WS protocols) - and each of these point to /webservice as their root location.

      As a consequence, we cannot introduce core_webservice AMD modules (webservice/amd/) or strings (webservice/lang/) because they would be considered as new WS protocols webservice_amd and webservice_lang respectively.

      Attachments

        Issue Links

          Activity

            People

              mudrd8mz David Mudrák (@mudrd8mz)
              mudrd8mz David Mudrák (@mudrd8mz)
              Carlos Escobedo Carlos Escobedo
              Adrian Greeve Adrian Greeve
              Gladys Basiana Gladys Basiana
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Mar/20

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 5 minutes
                  3h 5m