[MDL-67830] Error being logged when navigating from gradebook to quiz - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.4, 3.8.1, 3.9
Fix Version/s: 3.7.5, 3.8.2
Component/s: Quiz
Labels:
- ci
- release_notes
- triaged

Testing Instructions:
Hide

Make sure you have Debugging set to developer level.

Create a course.

Add a quiz.

Add a true-false question.

Attempt the quiz as a student.

As a teacher, go to the gradebook, grader report.

Find the student's grade, and click the 'Grade analysis' magnifying glass icon.

Verify that no PHP Notice is output during the redirect.
Show
Make sure you have Debugging set to developer level. Create a course. Add a quiz. Add a true-false question. Attempt the quiz as a student. As a teacher, go to the gradebook, grader report. Find the student's grade, and click the 'Grade analysis' magnifying glass icon. Verify that no PHP Notice is output during the redirect.
Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull 3.7 Branch:
~~MDL-67830~~_37
Pull 3.7 Diff URL:
https://github.com/timhunt/moodle/compare/MOODLE_37_STABLE...MDL-67830_37
Pull 3.8 Branch:
~~MDL-67830~~_38
Pull 3.8 Diff URL:
https://github.com/timhunt/moodle/compare/MOODLE_38_STABLE...MDL-MDL-67830_38
Pull Master Branch:
~~MDL-67830~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-67830

Description

To reproduce:

Create a course.
Add a quiz.
Add a true-false question.
Attempt the quiz as a student.
As a teacher, go to the gradebook, grader report.
Find the student's grade, and click the 'Grade analysis' magnifying glass icon.

Actual result: an error appears in the logs:

Warning: count(): Parameter must be an array or an object that implements Countable in /.../www/html/vle/mod/quiz/attemptlib.php on line 1501 Call Stack:

0.0012   424440 1. {main}() /.../www/html/vle/mod/quiz/grade.php:0

1.3443 40166040 2. quiz_attempt->review_url() /.../www/html/vle/mod/quiz/grade.php:84

1.3443 40166040 3. quiz_attempt->page_and_question_url() /.../www/html/vle/mod/quiz/attemptlib.php:1492

1.3443 40166040 4. quiz_attempt->get_default_show_all() /.../www/html/vle/mod/quiz/attemptlib.php:2151

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-67830.jpg
35 kB
06/Feb/20 10:12 AM

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: Mahmoud Kassaei

Integrator:: Eloy Lafuente (stronk7)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Mahmoud Kassaei, Tim Hunt

Component watchers:: Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 29/Jan/20 11:08 PM

Updated:: 04/Mar/20 4:12 PM

Resolved:: 07/Feb/20 5:13 PM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

40m