Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67862

Empty h3 tag in message deletion dialogue

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Prerequisite
      1. Install the WAVE browser extension
      2. Users s1 and s2 enrolled in a course. Make sure that s1 and s2 don't have a conversation between them yet.
      Accessibility test
      1. Log in as s1.
      2. Press the WAVE icon on your browser.
      3. On the WAVE panel, click on the "Details" tab.
      4. Confirm that there's no "Empty heading" error.
      Regression test
      1. As s1, open your messaging drawer.
      2. Click on the cog to open the settings.
      3. Choose "My contacts" only under Privacy.
      4. In another browser session, log in as s2.
      5. Open this browser session's JavaScript console
      6. Open the messaging app.
      7. Search for s1's name.
      8. Click s1's name.
      9. Check the dialogue
      10. Confirm that the dialogue contains a heading that says "[s1's full name] is not in your contacts"
      11. Confirm that you don't see any errors in the JS console.
      12. Press "Send contact request"
      13. Check the add contact confirmation dialogue.
      14. Confirm that you don't see a heading in the dialogue.
      15. Confirm that you don't see any errors in the JS console.
      16. Press "Cancel" and navigate back to the main view of the messaging app.
      17. Confirm that you don't see any errors in the JS console.
      Show
      Prerequisite Install the WAVE browser extension Users s1 and s2 enrolled in a course. Make sure that s1 and s2 don't have a conversation between them yet. Accessibility test Log in as s1. Press the WAVE icon on your browser. On the WAVE panel, click on the " Details " tab. Confirm that there's no " Empty heading " error. Regression test As s1, open your messaging drawer. Click on the cog to open the settings. Choose " My contacts " only under Privacy. In another browser session, log in as s2. Open this browser session's JavaScript console Open the messaging app. Search for s1's name. Click s1's name. Check the dialogue Confirm that the dialogue contains a heading that says " [s1's full name] is not in your contacts " Confirm that you don't see any errors in the JS console. Press " Send contact request " Check the add contact confirmation dialogue. Confirm that you don't see a heading in the dialogue. Confirm that you don't see any errors in the JS console. Press "Cancel" and navigate back to the main view of the messaging app. Confirm that you don't see any errors in the JS console.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.7 Branch:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67862-master
    • Story Points:
      0
    • Sprint:
      International 3.9 - Sprint 5, International 3.9 - Sprint 6

      Description

      From the audit results:

      Issue

      Empty headings

      There is an empty H3 present in the "Chat" area.
      Fig. 0.01

      Impact on users

      Screen reader users can call up a list of headings. Empty headings can cause confusion.

      Guidelines affected
      • 1.3.1 Info and Relationships (AA)
        • Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text.
      • 4.1.2 Name, Role, Value (A)
        • For all user interface components (including but not limited to: form elements, links and components generated by scripts), the name and role can be programmatically determined; states, properties, and values that can be set by the user can be programmatically set; and notification of changes to these items is available to user agents, including assistive technologies.
      Recommendation

      Delete the empty headings

        Attachments

          Activity

            People

            Assignee:
            jpataleta Jun Pataleta
            Reporter:
            jpataleta Jun Pataleta
            Peer reviewer:
            Michael Hawkins
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Mar/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 5 hours, 31 minutes
                1d 5h 31m