Loading...

XML

Word

Printable

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull Main Branch:
~~MDL-67878~~
Pull Main Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-67878
Testing Instructions:

Hide

Travis build verifies that this fix does not cause regressions on Linux.

Either find a Windows machine with a Moodle developer set-up, and verify grunt works there, or be satisfied with my testing that this fix works on Windows.

Show
Travis build verifies that this fix does not cause regressions on Linux. Either find a Windows machine with a Moodle developer set-up, and verify grunt works there, or be satisfied with my testing that this fix works on Windows.

Using master branch (3.9 dev) grunt is completely broken in windows using git bash. It does not matter what commend you try to run, you get

$ node_modules/grunt/bin/grunt amd --root=theme/boost/amd

>> Setting root to C:\Users\tjh238\workspace\moodle_head\theme\boost\amd

Loading "Gruntfile.js" tasks...ERROR

>> Error: ENOENT: no such file or directory, lstat 'C:\Users\tjh238\workspace\moodle_head\C:'

Warning: Task "amd" not found. Use --force to continue.

Aborted due to warnings.

$ node_modules/grunt/bin/grunt --watch

Loading "Gruntfile.js" tasks...ERROR

>> Error: ENOENT: no such file or directory, lstat 'C:\Users\tjh238\workspace\moodle_head\C:'

Warning: Task "default" not found. Use --force to continue.

Aborted due to warnings.

It works on my 3.8 checkout.

blocks

MDL-67949 Windows issues with generating ignoresfiles, and with watching in themes

is a regression caused by

MDL-67449 Grunt amd:dist very slow

Testing discovered

MDL-67953 Grunt window gherkinlint does not work

MDL-67949 Windows issues with generating ignoresfiles, and with watching in themes

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), John Beedell, Luca Bösch, Tim Hunt

Estimated:

Not Specified

Remaining:

Logged:

2h 56m