Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67882

Admin changes to the message notifications settings are not logged to config log

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1) Visit /report/configlog/index.php
      2) Confirm there are no recent changes
      3) Go to /admin/message.php
      4) Save without making any changes
      5) Confirm that /report/configlog/index.php has no extra changes
      6) Make changes to any of the Notification Plugins checkboxes
      7) Make changes to the Default notification preferences checkboxes and dropdowns
      8) Confirm that all changes above are shown in the configlog
      9) Make changes to both the Notification Plugin checkboxes and the Default notification preferences of another plugin
      10) Confirm that the changes to the Notification Plugins as well as Default notification preferences appear on the log
      11) Whilst completing step 10, make sure no changes are being logged where the preference has not changed but instead the order of the values have changed, e.g. a false positive where new value: "email,jabber" and old value: "jabber,email" are being logged. 

      Show
      1) Visit /report/configlog/index.php 2) Confirm there are no recent changes 3) Go to /admin/message.php 4) Save without making any changes 5) Confirm that /report/configlog/index.php has no extra changes 6) Make changes to any of the Notification Plugins checkboxes 7) Make changes to the Default notification preferences checkboxes and dropdowns 8) Confirm that all changes above are shown in the configlog 9) Make changes to both the Notification Plugin checkboxes and the Default notification preferences of another plugin 10) Confirm that the changes to the Notification Plugins as well as Default notification preferences appear on the log 11) Whilst completing step 10, make sure no changes are being logged where the preference has not changed but instead the order of the values have changed, e.g. a false positive where new value: "email,jabber" and old value: "jabber,email" are being logged. 
    • Affected Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      mdl-67882

      Description

      Any changes done here are not logged or auditable:

      /admin/message.php

       

        Attachments

          Activity

            People

            Assignee:
            brendanheywood Brendan Heywood
            Reporter:
            brendanheywood Brendan Heywood
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated: