Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67920

Move 'Upload H5P content types' button into the form and change page title and heading in 'Manage H5P content types' admin page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as admin.
      2. Go to site administration > Front page > Front page settings.
      3. Take note of the 'Full site name' and 'Short name for site' settings value.
      4. Go to site administration > H5P > Manage H5P content types.
      5. Confirm the title of the page is 'shortname setting value: Manage H5P content types' format (i.e 'integration_master: Manage H5P content types').
      6. Confirm the heading of the page is fullsitename setting value.
      7. Collapse form clicking in the 'Upload H5P content types' link.
      8. Check the 'Upload H5P content types' button and the 'H5P content type' field are hidden.
      Show
      Login as admin. Go to site administration > Front page > Front page settings. Take note of the 'Full site name' and 'Short name for site' settings value. Go to site administration > H5P > Manage H5P content types. Confirm the title of the page is 'shortname setting value: Manage H5P content types' format (i.e 'integration_master: Manage H5P content types'). Confirm the heading of the page is fullsitename setting value. Collapse form clicking in the 'Upload H5P content types' link. Check the 'Upload H5P content types' button and the 'H5P content type' field are hidden.
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67920-master

      Description

      Site administration > H5P > Manage H5P content types admin page 'Upload H5P content types' button is outside the form, so when the user collapses the form, the button is still visible. The button should be moved into the form to hide whenever the form is collapsed.

      And the title and heading of this page is not consistent with the other admin pages. Title should be 'siteshortname: Manage H5P content types' and heading 'sitefullname' 

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              amaia Amaia Anabitarte
              Reporter:
              amaia Amaia Anabitarte
              Peer reviewer:
              Sara Arjona (@sarjona)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Mar/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 35 minutes
                  1h 35m