Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67921

Review getOption implementation in H5P Framework

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.8
    • 3.8.2
    • H5P

    Description

      The implementation we did in framework.php for getOption method is not valid, because it should return the stored setting with $name (or $default if it's not found) instead of \H5PDisplayOptionBehaviour::CONTROLLED_BY_AUTHOR_DEFAULT_OFF.

      This value (\H5PDisplayOptionBehaviour::CONTROLLED_BY_AUTHOR_DEFAULT_OFF) should be returned only, at least for now, for DISPLAY_OPTION_DOWNLOAD and DISPLAY_OPTION_EMBED.

      Attachments

        Issue Links

          Activity

            People

              sarjona Sara Arjona (@sarjona)
              sarjona Sara Arjona (@sarjona)
              Carlos Escobedo Carlos Escobedo
              Jun Pataleta Jun Pataleta
              CiBoT CiBoT
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                9/Mar/20

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 50 minutes
                  4h 50m