[MDL-67942] Quiz: report delete_selected_attempts notice when a user has multiple enrolments - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.4, 3.8.1, 3.9
Fix Version/s: 3.7.5, 3.8.2
Component/s: Quiz
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/HuongNV13/moodle
Pull Master Branch:
~~MDL-67942~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...HuongNV13:MDL-67942-master
Testing Instructions:
Hide

Login as admin

Set "debug" to developer level and enable "debugdisplay"

Create a new role ( Site administration > Users > Permissions > Define roles > Add a new role) which allows these two capabilities: mod/quiz:attempt and mod/quiz:reviewmyattempts.

Create a user

Create a course, with a quiz having 1 question

Enrol the created user with 2 roles to the created course (Student role and the new one also).

Login as that user and complete the Quiz.

Login as admin.

Go to any Quiz reports (Grade, Response).

Select the attempt of that user and delete that attempt.

Verify that there isn't any error like the one shown in the description of the issue.
Show
Login as admin Set "debug" to developer level and enable "debugdisplay" Create a new role ( Site administration > Users > Permissions > Define roles > Add a new role) which allows these two capabilities: mod/quiz:attempt and mod/quiz:reviewmyattempts . Create a user Create a course, with a quiz having 1 question Enrol the created user with 2 roles to the created course (Student role and the new one also). Login as that user and complete the Quiz. Login as admin. Go to any Quiz reports (Grade, Response). Select the attempt of that user and delete that attempt. Verify that there isn't any error like the one shown in the description of the issue.

Description

In quiz attempt report, if you delete an attempt which belongs to a user that was enrolled in more than one role, you will get the error:

Did you remember to make the first column something unique in your call to get_records? Duplicate value 'xxxx' found in column 'id'.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

screenshot-1.png
142 kB
20/Feb/20 9:33 AM

Issue Links

Testing discovered

MDL-68000 delete_selected_attempts in mod/quiz/report/attemptsreport.php does a DB query in a loop

Open

Activity

People

Assignee:: Huong Nguyen

Reporter:: Huong Nguyen

Peer reviewer:: Tim Hunt

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: CiBoT, Eloy Lafuente (stronk7), Huong Nguyen, Janelle Barcega, Tim Hunt

Component watchers:: Tim Hunt, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Kevin Percy, Laurent David, Mathew May, Mihail Geshoski, Raquel Ortega, Sabina Abellan, Sander Bangma, Sara Arjona (@sarjona), Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 12/Feb/20 3:23 PM

Updated:: 05/Mar/20 3:04 PM

Resolved:: 21/Feb/20 11:39 AM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 45m