Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67949

Windows issues with generating ignoresfiles, and with watching in themes

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      These testing instructions must be run on both Windows and a Unix-like OS

      ignorefiles

      1. Run ignorefiles:

        grunt ignorefiles
        

      2. Check that there were no changes:

        git diff
        

        1. Confirm that there were no changes

      component directory for theme/amd

      1. Change into the theme/boost directory:

        cd theme/boost
        

      2. Run grunt in watch mode:

        grunt watch
        

      3. Open another terminal
      4. Touch a scss file:

        touch scss/moodle/login.scss
        

        1. Confirm that the other terminal window picked up the file being changed
      5. Touch an AMD file:

        touch amd/src/util.js
        

        1. Confirm that the other terminal window picked up the file being changed
      Show
      These testing instructions must be run on both Windows and a Unix-like OS ignorefiles Run ignorefiles: grunt ignorefiles Check that there were no changes: git diff Confirm that there were no changes component directory for theme/amd Change into the theme/boost directory: cd theme/boost Run grunt in watch mode: grunt watch Open another terminal Touch a scss file: touch scss/moodle/login.scss Confirm that the other terminal window picked up the file being changed Touch an AMD file: touch amd/src/util.js Confirm that the other terminal window picked up the file being changed
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-67949-master

      Description

      From Eloy Lafuente (stronk7):

      1. Watch a theme directory : touches to target files don't awake grunt.
      2. Watch an amd directory : touches to target files don't awake grunt.
      3. grunt ignorefiles : it's generating the .ignore files with Windows paths.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              dobedobedoh Andrew Lyons
              Peer reviewer:
              Tim Hunt Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Time Spent - 4 hours, 8 minutes Remaining Estimate - 4 days, 1 hour, 46 minutes
                  4d 1h 46m
                  Logged:
                  Time Spent - 4 hours, 8 minutes Remaining Estimate - 4 days, 1 hour, 46 minutes
                  4h 8m