[MDL-67965] Subsystems with named selectors should be overridable by themes - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Blocker
Resolution: Fixed
Affects Version/s: 3.5.10, 3.6.8, 3.7.4, 3.8.1, 3.9
Fix Version/s: 3.5.11, 3.6.9, 3.7.5, 3.8.2
Component/s: Automated functional tests (behat)
Labels:
- ci

Testing Instructions:
Hide

Apply the attached patch (beware there are different versions for 35/36, and 37+):

git am test_37_38_master.patch

# OR

git am test_35_36.patch

Init behat:

php admin/tool/behat/cli/init.php -a

Run the supplied test on boost using the command printed during init, and the test file blocks/settings/tests/behat/test.feature:

php admin/tool/behat/cli/run.php --name="I test 67965"

Confirm that the test passes

Confirm that there were 4 dots (37, 38, master)

Confirm that there were 6 dots (35, 36)
Show
Apply the attached patch (beware there are different versions for 35/36, and 37+): git am test_37_38_master.patch # OR git am test_35_36.patch Init behat: php admin/tool/behat/cli/init.php -a Run the supplied test on boost using the command printed during init, and the test file blocks/settings/tests/behat/test.feature : php admin/tool/behat/cli/run.php --name="I test 67965" Confirm that the test passes Confirm that there were 4 dots (37, 38, master) Confirm that there were 6 dots (35, 36)
Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull 3.5 Branch:
~~MDL-67965~~-35
Pull 3.5 Diff URL:
https://github.com/andrewnicols/moodle/compare/84a9a24b96...MDL-67965-35
Pull 3.7 Branch:
~~MDL-67965~~-37
Pull 3.7 Diff URL:
https://github.com/andrewnicols/moodle/compare/59f947667a...MDL-67965-37
Pull 3.8 Branch:
~~MDL-67965~~-38
Pull 3.8 Diff URL:
https://github.com/andrewnicols/moodle/compare/9691980198...MDL-67965-38
Pull Master Branch:
~~MDL-67965~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/cb38ab1e39...MDL-67965-master

Description

We allowed components to define named selectors and replacements in ~~MDL-66559~~ for 3.5 onwards, but it appears that these do not work properly where there exists a theme override of that context.

Discovered in testing of ~~MDL-67264~~

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

test_35_36.patch
3 kB
14/Feb/20 11:08 AM
test_37_38_master.patch
2 kB
14/Feb/20 10:46 AM
test_result_67965.png
277 kB
14/Feb/20 6:53 PM

Issue Links

Discovered while testing

MDL-67264 Rework/Redesign the activity chooser

Closed

Activity

People

Assignee:: Andrew Nicols

Reporter:: Andrew Nicols

Peer reviewer:: Mathew May

Integrator:: Jun Pataleta

Tester:: Sara Arjona (@sarjona)

Participants:: Andrew Nicols, CiBoT, Jun Pataleta, Mathew May, Sara Arjona (@sarjona)

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 14/Feb/20 9:51 AM

Updated:: 14/Feb/20 7:47 PM

Resolved:: 14/Feb/20 7:47 PM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

3h 55m