Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67965

Subsystems with named selectors should be overridable by themes

XMLWordPrintable

    • MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • MDL-67965-master
    • Hide
      1. Apply the attached patch (beware there are different versions for 35/36, and 37+): 

        git am test_37_38_master.patch
        		 
        # OR
        		 
        git am test_35_36.patch

      2. Init behat: 

        php admin/tool/behat/cli/init.php -a

      3. Run the supplied test on boost using the command printed during init, and the test file blocks/settings/tests/behat/test.feature: 

        php admin/tool/behat/cli/run.php --name="I test 67965"

        1. Confirm that the test passes
        2. Confirm that there were 4 dots (37, 38, master)
        3. Confirm that there were 6 dots (35, 36)
      Show
      Apply the attached patch (beware there are different versions for 35/36, and 37+): git am test_37_38_master.patch # OR git am test_35_36.patch Init behat: php admin/tool/behat/cli/init.php -a Run the supplied test on boost using the command printed during init, and the test file blocks/settings/tests/behat/test.feature : php admin/tool/behat/cli/run.php --name="I test 67965" Confirm that the test passes Confirm that there were 4 dots (37, 38, master) Confirm that there were 6 dots (35, 36)

      We allowed components to define named selectors and replacements in MDL-66559 for 3.5 onwards, but it appears that these do not work properly where there exists a theme override of that context.

      Discovered in testing of MDL-67264

        1. test_35_36.patch
          3 kB
        2. test_37_38_master.patch
          2 kB
        3. test_result_67965.png
          test_result_67965.png
          277 kB

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Glyn (Mathew) May Glyn (Mathew) May
            Jun Pataleta Jun Pataleta
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 55 minutes
                3h 55m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.