Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67968

Calendar: New event: Accessibility issues

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Requirements

      Test 1

      1. Log in as admin
      2. Go to the calendar page
      3. Click on the 'New event' button
      4. Click on the label text of the date field
      5. Verify that the day element of the date field is focused
      6. Click on 'Show more...' link
      7. Press the WAVE icon on your browser.
      8. Visit the 'Details' tab in the WAVE panel
      9. Verify that you do not see any "Orphaned form label" alert
      10. Verify that you do not see any "Empty form label" error that is related to the new event form
        • you may see one "Empty form label" error that is for the course filter, outside the new event form

      Test 2

      1. Log in as admin
      2. Go to the calendar page
      3. Enable the screen reader
      4. Make your screen reader pronounce the day titles on the calendar. (instruction depends on the screen reader you use. for example, you may have to click on the week name cells)
      5. Verify that the screen reader announces full week day names (like Monday, not Mon)
      6. Repeat the steps 4 and 5 with the mini-calendar blocks

      Test 3

      1. Log in as admin
      2. Visit site home page
      3. From the cog icon, go to 'More... > Question bank > Questions'
      4. Click on the 'Create a new question...' button
      5. Select 'Drag and drop into text' and click on the 'Add' button
      6. Expand the 'choices' section in the form if it is not already expanded
      7. Verify that you do not see 'choice [[x]]' title more than once on each row
      Show
      Requirements You'd need the  WAVE browser extension  for this test You'd need a screen reader Test 1 Log in as admin Go to the calendar page Click on the 'New event' button Click on the label text of the date field Verify that the day element of the date field is focused Click on 'Show more...' link Press the WAVE icon on your browser. Visit the 'Details' tab in the WAVE panel Verify  that you do not see any "Orphaned form label" alert Verify that you do not see any "Empty form label" error that is related to the new event form you may see one "Empty form label" error that is for the course filter, outside the new event form Test 2 Log in as admin Go to the calendar page Enable the screen reader Make your screen reader pronounce the day titles on the calendar. (instruction depends on the screen reader you use. for example, you may have to click on the week name cells) Verify that the screen reader announces full week day names (like Monday, not Mon) Repeat the steps 4 and 5 with the mini-calendar blocks Test 3 Log in as admin Visit site home page From the cog icon, go to 'More... > Question bank > Questions' Click on the 'Create a new question...' button Select 'Drag and drop into text' and click on the 'Add' button Expand the 'choices' section in the form if it is not already expanded Verify that you do not see 'choice [ [x] ]' title more than once on each row
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull from Repository:
    • Pull 3.7 Branch:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-67968-master
    • Story Points:
      2
    • Sprint:
      International 3.9 - Sprint 6, International 3.9 - Sprint 7

      Description

      Issues

      Strikethrough issues won't be done here (a comment has been added into the description to clarify how they will be processed).

      A
      1. No label. See:
        • Fig. 5.01.png. This is a false positive. WAVE complains about missing label for a select element that is hidden. not only by visibility: hidden; display: none; style, but also by aria-hidden="true", so nothing will be done here.
        • Fig. 5.02.png
        • Fig. 5.03.png
      2. Errors were found using W3C Nu Validation Service and filtered to indicate WCAG errors only. Nothing to do here because these errors will be done in:
        • Duplicate ID for site blocks. Fixed as part of MDL-67969
        • Invalid 'for' attribute for the course selector on the view calendar page. Fixed as part of MDL-67902
      AA
      1. Colour contrast #3, #4. Will be addressed on MDL-64494
      AAA
      1. There is a loss of data after a re-authentication. This has been left out as it was AAA and as it required a massive amount of work and a lot of code refactoring
      2. Abbreviations such as "Sun", "Mon" etc. are not fully explained. Even well known abbreviations need to either be expanded on the first use on a page or that a link to a glossary or list of terms be provided

       

      Affected guidelines
      A
      • Info and Relationships:
        1.3.1 Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text.
      • Labels or Instructions
        3.3.2 Labels or instructions are provided when content requires user input
      • Parsing:
        4.1.1 In content implemented using markup languages, elements have complete start and end tags, elements are nested according to their specifications, elements do not contain duplicate attributes, and any IDs are unique, except where the specifications allow these features. Note: Start and end tags that are missing a critical character in their formation, such as a closing angle bracket or a mismatched attribute value quotation mark are not complete.
      AA
      • Non-text Contrast:
        1.4.11 The visual presentation of the following have a contrast ratio of at least 3:1 against adjacent color(s):
        User Interface Components
        Visual information required to identify user interface components and states, except for inactive components or where the appearance of the component is determined by the user agent and not modified by the author;
        Graphical Objects
        Parts of graphics required to understand the content, except when a particular presentation of graphics is essential to the information being conveyed.
      AAA
      • Re-authenticating:
        2.2.5 When an authenticated session expires, the user can continue the activity without loss of data after re-authenticating.
      • Abbreviations:
        3.1.4 A mechanism for identifying the expanded form or meaning of abbreviations is available.
      Affected browsers
      • All

        Attachments

        1. dropzone.png
          dropzone.png
          202 kB
        2. Fig. 5.01.png
          Fig. 5.01.png
          11 kB
        3. Fig. 5.02.png
          Fig. 5.02.png
          9 kB
        4. Fig. 5.03.png
          Fig. 5.03.png
          11 kB
        5. filetypes.png
          filetypes.png
          1.14 MB
        6. filetypes.png
          filetypes.png
          1.14 MB
        7. image-2020-02-25-03-28-19-099.png
          image-2020-02-25-03-28-19-099.png
          111 kB
        8. MDL-67968_Test1.jpg
          MDL-67968_Test1.jpg
          63 kB
        9. MDL-67968_Test2_Step5.mp4
          639 kB
        10. MDL-67968_Test2_Step6.mp4
          600 kB
        11. MDL-67968_Test3.jpg
          MDL-67968_Test3.jpg
          23 kB
        12. Screenshot 2020-02-24 at 15.51.44.png
          Screenshot 2020-02-24 at 15.51.44.png
          150 kB
        13. wave.png
          wave.png
          282 kB

          Issue Links

            Activity

              People

              Assignee:
              rezaie9 Shamim Rezaie
              Reporter:
              rezaie9 Shamim Rezaie
              Peer reviewer:
              Bas Brands
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 7 hours, 21 minutes
                  2d 7h 21m