[MDL-67980] Sort ad-hoc tasks by "nextruntime" - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.4, 3.8.1, 3.9
Fix Version/s: 3.7.5, 3.8.2
Component/s: Tasks
Labels:
- CatalystIT
- ci
- partner
- release_notes
- triaged

Testing Instructions:
Hide

1) Run PHPUnit test:

vendor/bin/phpunit --filter='test_get_next_adhoc_task_sorting' lib/tests/adhoc_task_test.php

2) Confirm, that it is successful.
Show
1) Run PHPUnit test: vendor/bin/phpunit --filter= 'test_get_next_adhoc_task_sorting' lib/tests/adhoc_task_test.php 2) Confirm , that it is successful.
Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/golenkovm/moodle.git
Pull 3.7 Branch:
MOODLE_37_~~MDL-67980~~
Pull 3.7 Diff URL:
https://github.com/moodle/moodle/compare/d077ffd3a57...golenkovm:MOODLE_37_MDL-67980
Pull 3.8 Branch:
MOODLE_38_~~MDL-67980~~
Pull 3.8 Diff URL:
https://github.com/moodle/moodle/compare/7b3746671...golenkovm:MOODLE_38_MDL-67980
Pull Master Branch:
master_~~MDL-67980~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/37b2ee3f6...golenkovm:master_MDL-67980

Description

Currently, there is no sorting in `get_next_adhoc_task()` method:

https://github.com/moodle/moodle/blob/2c0b08c5a7e8c682f0621abb74a5eaf3817b0114/lib/classes/task/manager.php#L562-L564

Therefore, database engine returns unsorted set of records and under some circumstances records with more recent `nextruntime` can go ahead of records with later `nextruntime`.

In scenario when we are catching up with some ad-hoc tasks we want the latest tasks to be processed first.

To guarantee this we should add explicit sorting by `nextruntime`.

Attachments

Activity

People

Assignee:: Mikhail Golenkov

Reporter:: Mikhail Golenkov

Peer reviewer:: Brendan Heywood

Integrator:: Jun Pataleta

Tester:: CiBoT

Participants:: Brendan Heywood, CiBoT, Jun Pataleta, Mikhail Golenkov

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 17/Feb/20 7:34 AM

Updated:: 04/Mar/20 6:25 PM

Resolved:: 28/Feb/20 8:34 PM

Fix Release Date:: 9/Mar/20

Time Tracking

Estimated:

Remaining:

Logged:

30m