Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67991

label-warning displayed when adding restrictions to an activity

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test for both Boost and Classic themes:

      1. As a teacher create a course with 'Enable completion tracking' = Yes setting.
      2. Create an assignment in the course.
      3. Ensure the 'Completion tracking' for the created assignment  is enabled. For example. 'Students can manually mark the activity as completed'
      4. Save and return to course
      5. Create a new assignment and go to 'Restrict access' section.
      6. Add a restriction... > Activity completion
        1. Confirm there is a 'Please set' yellow label in the right side of the X 'Delete' icon
      7. Choose an activity from the dropdown
        1. Confirm the yellow label disappears
      8. Add a restriction... > Date
        1. Confirm there is no empty yellow label in the right of the X 'Delete' icon
          The following is an example of the empty yellow label that you should no longer see:
      Show
      Test for both Boost and Classic themes: As a teacher create a course with 'Enable completion tracking' = Yes setting. Create an assignment in the course. Ensure the 'Completion tracking' for the created assignment  is enabled. For example. 'Students can manually mark the activity as completed' Save and return to course Create a new assignment and go to 'Restrict access' section. Add a restriction... > Activity completion Confirm there is a 'Please set' yellow label in the right side of the X 'Delete' icon Choose an activity from the dropdown Confirm the yellow label disappears Add a restriction... > Date Confirm there is no empty yellow label in the right of the X 'Delete' icon The following is an example of the empty yellow label that you should no longer see:
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.9 Branch:
    • Pull Master Branch:
      MDL-67991-master
    • Sprint:
      Moppies Kanban

      Description

      Steps to reproduce:

      1. Login as admin.
      2. Create a course. Enable completion tracking for this course.
      3. Add an activity to the course (let's say, an assignment).
      4. Create another activity to the course (for instance, another assignment). During the activity creation, add a restriction with "Activity completion" and select the previous activity.

      Unexpected behaviour:

      A label-warning is displayed next to the delete button x (a screenshot is attached to display it).

       

      I've been able to reproduce it only in master (in 3.8 is working as expected).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              amaia Amaia Anabitarte
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Ferran Recio
              Integrator:
              Andrew Nicols
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 10 minutes
                  1d 10m