Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67992

In any child theme of Boost the config icon_system standard does not work

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major Major
    • None
    • 3.8
    • Themes
    • MOODLE_38_STABLE

      The reason is, that \core\output\icon_system_standard does not extend icon_system. Therefore the check if the selected icon system is valid fails. \theme_config::get_icon_system checks \core\output\icon_system::is_valid_system. When icon_system_standard does not extend icon_system the check fails.

      Changes to correct the bug

      from:

      class icon_system_standard {

      to:

      class icon_system_standard extends icon_system {

       

      How to test

      In a Boost child like »Classic« set 

      $THEME->iconsystem = \core\output\icon_system::STANDARD;

      Check the icons - they are still shown as fontawesome icons. After the patch the Moodle standard icons are shown.

        1. inheritance.png
          14 kB
          Eloy Lafuente (stronk7)

            stronk7 Eloy Lafuente (stronk7)
            urshunkler Urs Hunkler
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.