Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68003

Session timeout warning should not appear inside iframes

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE
    • Pull from Repository:
    • Pull 3.10 Branch:
      MDL-68003_310
    • Pull 3.10 Diff URL:
    • Pull 3.11 Branch:
      MDL-68003_311
    • Pull 3.11 Diff URL:
    • Pull Master Branch:
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide

      Setup

      1. Install https://moodle.org/plugins/filter_embedquestion
      2. Create a course.
      3. In the question bank, create a Question category with an idnumber set.
      4. In that category, create a true/false question with an idnumber.
      5. In admin settings, set the Moodle session timeout to something short.

      Test

      1. Go to .../filter/embedquestion/testhelper.php?courseid=XX in you Moodle site, where XX is the id of your test course.
      2. Fill in the form to embed your test question.
      3. Click the button to do the embed.
      4. Wait until the session timeout warning appears.
      5. Verify that the session timeout warning appears in the top-level window, but not the embedded question iframe.
      Show
      Setup Install https://moodle.org/plugins/filter_embedquestion Create a course. In the question bank, create a Question category with an idnumber set. In that category, create a true/false question with an idnumber. In admin settings, set the Moodle session timeout to something short. Test Go to .../filter/embedquestion/testhelper.php?courseid=XX in you Moodle site, where XX is the id of your test course. Fill in the form to embed your test question. Click the button to do the embed. Wait until the session timeout warning appears. Verify that the session timeout warning appears in the top-level window, but not the embedded question iframe.

      Description

      This can be seen with https://moodle.org/plugins/filter_embedquestion, and may also affect H5P.

      The new session time-out pop-up may affect this (and this should probably be tested). The steps below describe the behaviour with that warning disabled.

      Steps to reproduce:

      1. Set up an embedded question in a page.
      2. Log in as student, and type in an answer to the question, but don't submit yet.
      3. Simulate logging out by using yoru browser developer tools to edit or delete the Moodle session cookie.
      4. Now click Submit in the iframe.

      Actual result: the login form appears in the iframe if you are using standard Moodle login, which is a bit weird.

      Acutal result, if you are using a single-sign-on system: the third-party login form appears in the iframe, but then does not work.

      Expected result: ... to be honest, I am not sure, but this behaviour is weird.

      Suggestion: when this happens, the top level page reloads, triggering you to log in in the main browser window???

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Sam Marshall Sam Marshall
            Integrator:
            Andrew Lyons Andrew Lyons
            Tester:
            Gladys Basiana Gladys Basiana
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Jul/21

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 20 minutes
                3h 20m