Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68008

tool_capability only shows multiple contexts when all selected caps have overrides

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Testing Setup:

      1. Log in as admin
      2. Create a course
      3. Inside the course administration got to users -> permissions and allow the enrol/category:config to the student role.
      4. Go to  admin -> Users -> Perms -> Capability overview

      Test 1: normal overview (on version 3.7, 3.8 and 3.9)

      1. Select:
        1. Capability: enrol/category:config
        2. Roles: all roles
        3. Click on "Get the overview" button.
      2. Then you should see various sections in the report: Permissions in System, in Miscellaneous, in Course, showing the override.
      3. Now select
        1. Capability: enrol/category:config and enrol/cohort:config (that has not overrides)
        2. Roles: all roles
        3. Click on "Get the overview" button.
      4. Then you should see also various sections in the report: Permissions in System, in Miscellaneous, in Course, showing the override for "enrol/category:config" and Inherit for "enrol/cohort:config".

      Test 2: show differences only overview (only in 3.9)

      1. Select:
        1. Capability: enrol/category:config
        2. Roles: Student and Teacher
        3. Activate "Show differences only"
        4. Click on "Get the overview" button.
      2. Then you should see various sections in the report:
        1. Permissions in System (with the capability)
        2. Permissions Miscellaneous (Saying that there are no differences)
        3. Permissions in Course (showing the override).
      3. Now select
        1. Capability: enrol/category:config and enrol/cohort:config (that has not overrides)
        2. Roles: Student and Teacher
        3. Activate"Show differences only"
        4. Click on "Get the overview" button.
      4. Then you should see also various sections in the report:
        1. Permissions in System (with both capabilities)
        2. Permissions Miscellaneous (Saying that there are no differences)
        3. Permissions in Course (with only enrol/category:config).

       

      Show
      Testing Setup: Log in as admin Create a course Inside the course administration got to users -> permissions and allow the enrol/category:config to the student role. Go to  admin -> Users -> Perms -> Capability overview Test 1: normal overview (on version 3.7, 3.8 and 3.9) Select: Capability: enrol/category:config Roles: all roles Click on "Get the overview" button. Then you should see various sections in the report: Permissions in System, in Miscellaneous, in Course, showing the override. Now select Capability: enrol/category:config and enrol/cohort:config (that has not overrides) Roles: all roles Click on "Get the overview" button. Then you should see also various sections in the report: Permissions in System, in Miscellaneous, in Course, showing the override for "enrol/category:config" and Inherit for "enrol/cohort:config". Test 2: show differences only overview (only in 3.9) Select: Capability: enrol/category:config Roles: Student and Teacher Activate "Show differences only" Click on "Get the overview" button. Then you should see various sections in the report: Permissions in System (with the capability) Permissions Miscellaneous (Saying that there are no differences) Permissions in Course (showing the override). Now select Capability: enrol/category:config and enrol/cohort:config (that has not overrides) Roles: Student and Teacher Activate"Show differences only" Click on "Get the overview" button. Then you should see also various sections in the report: Permissions in System (with both capabilities) Permissions Miscellaneous (Saying that there are no differences) Permissions in Course (with only enrol/category:config).  
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.7 Branch:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-68008-master
    • Sprint:
      Moppies Kanban

      Description

      This was discovered while testing MDL-50455.

       

      the "capability overview" report (admin -> Users -> Perms -> Capability overview) only shows multiple contexts if ALL the capabilities have overrides, and only for matching contexts.

      To reproduce:

      1) In a site, go to a course and allow the enrol/category:config to the student role.

      2) Go to  admin -> Users -> Perms -> Capability overview select the enrol/category:config and all roles. Click on "Get the overview" button.

      3) you will get various sections in the report: Permissions in System, in Miscellaneous, in Course, showing the override .

      4) Now select both enrol/category:config and enrol/cohort:config (that has not overrides).  Click on "Get the overview" button again.

      EXPECTED:

      The same information that was shown in 3) above for enrol/category:config  PLUS the information for enrol/cohort:config should be displayed (irrespectively of the later being "inherit" everywhere, because it has no overrides).

      CURRENT:

      Information for the 2 caps are shown but only for system context (no way to display the overrides)

       

      Reproduced in 3.9, but surely affects previous versions.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tusefomal Ferran Recio
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Simey Lameze
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Mar/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 18 minutes
                  4h 18m