Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68035

Assign plugin feedback not expanding in Safari

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 3.7.1
    • Fix Version/s: None
    • Component/s: Assignment
    • Labels:
    • Affected Branches:
      MOODLE_37_STABLE

      Description

      Using the assign activity, whenever the teacher leaves enough feedback to a submission, the section will be contracted, but the link on the expand '+' button does not work on Safari upon page loading.

      However, if we execute on the console:

       

      $('.expandsummaryicon')[0].click();

       

      The contract '-' and the expand '+' links start working normally.

       

      This behavior is found Safari for IOS as well as MacOS. On the other browsers it works as intended. 

       

      Tried fixes:

      On the file: mod/assign/renderer.php 

      There were 2 lines with this exact same call:

      $this->page->requires->js_init_call('M.mod_assign.init_plugin_summary', $jsparams);

      Those were changed to this: 

      $this->page->requires->js_init_call('M.mod_assign.init_plugin_summary', $jsparams, true);

      Adding the 3rd parameter which sets the ondomready value to true. but the behavior did not change and the Safari error remains.

       

      Please help!

       

      Best regards

       

      Felice

       

      PS: To contract the feedback via JS console on the navigator, you can execute:

      $('.expandsummaryicon')[1].click();

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              felicemcc Felice Candilio
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: