Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68042

Move tablelib to new classes

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Development in progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9
    • Fix Version/s: None
    • Component/s: General
    • Labels:
      None

      Description

      As part of our changes to support the new Participants Page filter project in the MDL-67743 epic, we are making a number of changes to make both flexible_table and table_sql 'dynamic' - that is AJAX updatable. The intent is to make this work for updating table content, re-sorting, showing and hiding rows, changing pages, filtering content, and any other similar activities.

      To make this easier we intend to introduce a number of new classes and interfaces and wish to move all of these to the core_table subsystem. This subsystem already exists, but is not currently configured with a directory, classes, GDPR configuration, etc.

      This issue seeks to move:

      1. \flexible_table to \core_table\flexible_table
      2. \table_sql to \core_table\sql_table
      3. All of the relevant TABLE_VAR_ and TABLE_P_ constants to class constants on the flexible_table class
      4. \table_default_export_format_parent to \core_table\local\dataformat
      5. \table_dataformat_export_format to \core_table\local\dataformat\export

      The side-benefits of things change will be that it is no longer necessary to necessary to include/require lib/tablelib.php.

      There are only about 50-60 uses of these in core.

      In addition to these changes, this issue seeks to correct coding style on all of the affected classes by:

      1. defining variable visibility where none was defined
      2. defining function visibility where none was defined, taking into account comments as to the 'public' nature of the function
      3. renaming variables where reasonable

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 54 minutes
                2d 54m