Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68079

Redis session handle doesn't correctly honor $lockexpire

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a bug
    • Icon: Minor Minor
    • None
    • 3.5.10, 3.6.8, 3.7.4, 3.8
    • Authentication
    • MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE

      Redis has this session:

      $CFG->session_redis_lock_expire

      https://github.com/moodle/moodle/blob/master/lib/classes/session/redis.php#L112-L115

      If for some reason a page seg faults or whatever then it will not shutdown php correctly and the session lock will not be removed.

      In theory after $lockexpire time has passed the lock can be regained and continue, but the code for this simply doesn't exist.

       

            Unassigned Unassigned
            brendanheywood Brendan Heywood
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.