Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68081

A small string error in lib/classes/event/group_member_removed.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.10, 3.6.8, 3.7.4, 3.8.1, 3.9
    • Fix Version/s: 3.7.6, 3.8.3
    • Component/s: Groups, Logging
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to a course with students enroled in it.
      2. Create a group and add some students to it.
      3. Once the group has been created, select the group and then click the "Add/remove users" button.
      4. Select a student and remove them from the group.
      5. Go back to the course and check the logs (Course administration > Reports > Logs)
      6. Leave all the options at their default and click "Get these logs"
      7. Look for the Group member removed event and check that the Description reads - The user with the id '&' removed the user with id '&' from the group with the id '&' (ampersand will be numbers relevant to your system).
      Show
      Go to a course with students enroled in it. Create a group and add some students to it. Once the group has been created, select the group and then click the "Add/remove users" button. Select a student and remove them from the group. Go back to the course and check the logs (Course administration > Reports > Logs) Leave all the options at their default and click "Get these logs" Look for the Group member removed event and check that the Description reads - The user with the id '&' removed the user with id '&' from the group with the id '&' (ampersand will be numbers relevant to your system).
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.7 Branch:
      MDL-68081-MOODLE_37_STABLE
    • Pull 3.8 Branch:
      MDL-68081-MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-68081-master

      Description

      There's an error in file lib/classes/event/group_member_removed.php, in function get_description.

      It should better be "The user with id... removed the user with id... from the group with " (and not "to").

        Attachments

          Activity

            People

            Assignee:
            kritisingh1 Kriti Singh
            Reporter:
            fox Séverin Terrier
            Peer reviewer:
            Simey Lameze
            Integrator:
            Adrian Greeve
            Tester:
            Shamim Rezaie
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 56 minutes
                56m