[MDL-68103] Classic theme still uses hidden-print class - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.8.1, 3.8.3, 3.9
Fix Version/s: 3.8.4
Component/s: Themes
Labels:
- ci
- triaged

Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Pull from Repository:
git://github.com/bmbrands/moodle.git
Pull Master Branch:
~~MDL-68103~~-master
Pull Master Diff URL:
https://github.com/bmbrands/moodle/compare/1afe68f382...MDL-68103-master
Testing Instructions:
Hide

Login as admin

Navigate to Site Administration > Appearance > Themes > Theme selector

Change your theme to Classic

Navigate to any page the has blocks

Try printing your page (to PDF)

Verify the printed page does not contain any blocks

Verify the printed page container takes up the full page width
Show
Login as admin Navigate to Site Administration > Appearance > Themes > Theme selector Change your theme to Classic Navigate to any page the has blocks Try printing your page (to PDF) Verify the printed page does not contain any blocks Verify the printed page container takes up the full page width

Description

As per ~~MDL-62322~~, classic theme should replace use of hidden-print with d-print-none class.

mod_book also uses hidden-print, but includes styling to the desired effect. If Bootstrap 4 can be assumed to be present, perhaps this should also change to d-print-none and the styling be removed as unnecessary (although there may be complications).

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

68103.png
2.14 MB
25/May/20 4:36 PM
boost.png
1.44 MB
15/Apr/20 7:47 PM
classic.png
1.49 MB
15/Apr/20 7:47 PM
MDL-68103.jpg
28 kB
26/May/20 12:12 PM
MDL-68103 (2).jpg
29 kB
26/May/20 12:12 PM

Activity

People

Assignee:: Nick Phillips

Reporter:: Nick Phillips

Peer reviewer:: Bas Brands

Integrator:: Andrew Lyons

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, Bas Brands, CiBoT, Nick Phillips

Component watchers:: Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 04/Mar/20 11:12 AM

Updated:: 27/May/20 5:22 AM

Resolved:: 27/May/20 5:22 AM

Fix Release Date:: 13/Jul/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

50m