Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68103

Classic theme still uses hidden-print class

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.8.1, 3.8.3, 3.9
    • 3.8.4
    • Themes
    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE
    • MDL-68103-master
    • Hide
      1. Login as admin
      2. Navigate to Site Administration > Appearance > Themes > Theme selector
      3. Change your theme to Classic
      4. Navigate to any page the has blocks
      5. Try printing your page (to PDF)
      6. Verify the printed page does not contain any blocks
      7. Verify the printed page container takes up the full page width
      Show
      Login as admin Navigate to Site Administration > Appearance > Themes > Theme selector Change your theme to Classic Navigate to any page the has blocks Try printing your page (to PDF) Verify the printed page does not contain any blocks Verify the printed page container takes up the full page width

    Description

      As per MDL-62322, classic theme should replace use of hidden-print with d-print-none class.

       

      mod_book also uses hidden-print, but includes styling to the desired effect. If Bootstrap 4 can be assumed to be present, perhaps this should also change to d-print-none and the styling be removed as unnecessary (although there may be complications).

      Attachments

        1. 68103.png
          68103.png
          2.14 MB
        2. boost.png
          boost.png
          1.44 MB
        3. classic.png
          classic.png
          1.49 MB
        4. MDL-68103.jpg
          MDL-68103.jpg
          28 kB
        5. MDL-68103 (2).jpg
          MDL-68103 (2).jpg
          29 kB

        Activity

          People

            nwpotago Nick Phillips
            nwpotago Nick Phillips
            Bas Brands Bas Brands
            Andrew Lyons Andrew Lyons
            Anna Carissa Sadia Anna Carissa Sadia
            Huong Nguyen, Bas Brands, Mathew May
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/Jul/20

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 50 minutes
                50m