Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68103

Classic theme still uses hidden-print class

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8.1, 3.8.3, 3.9
    • Fix Version/s: 3.8.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as admin
      2. Navigate to Site Administration > Appearance > Themes > Theme selector
      3. Change your theme to Classic
      4. Navigate to any page the has blocks
      5. Try printing your page (to PDF)
      6. Verify the printed page does not contain any blocks
      7. Verify the printed page container takes up the full page width
      Show
      Login as admin Navigate to Site Administration > Appearance > Themes > Theme selector Change your theme to Classic Navigate to any page the has blocks Try printing your page (to PDF) Verify the printed page does not contain any blocks Verify the printed page container takes up the full page width
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-68103-master

      Description

      As per MDL-62322, classic theme should replace use of hidden-print with d-print-none class.

       

      mod_book also uses hidden-print, but includes styling to the desired effect. If Bootstrap 4 can be assumed to be present, perhaps this should also change to d-print-none and the styling be removed as unnecessary (although there may be complications).

        Attachments

        1. MDL-68103 (2).jpg
          MDL-68103 (2).jpg
          29 kB
        2. MDL-68103.jpg
          MDL-68103.jpg
          28 kB
        3. classic.png
          classic.png
          1.49 MB
        4. boost.png
          boost.png
          1.44 MB
        5. 68103.png
          68103.png
          2.14 MB

          Activity

            People

            Assignee:
            nwpotago Nick Phillips
            Reporter:
            nwpotago Nick Phillips
            Peer reviewer:
            Bas Brands
            Integrator:
            Andrew Nicols
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jul/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 50 minutes
                50m