Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68108

Password field not styled on form group

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7.4, 3.8.1, DEV backlog
    • Fix Version/s: 3.7.6, 3.8.3
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      Currently, there's no case to test in Moodle.

      1. Copy passwordtest.php to your moodle instance's root folder.
      2. Open passwordtest.php on your browser.
      3. Confirm that the 'Grouped password fields' are styled in the same way as the 'Standalone password field'
      4. Go to the Template library.
      5. Search for "element-password".
      6. Click "core_form/element-password"
      7. Confirm that it is rendered and styled appropriately.
      8. Click "core_form/element-password-inline"
      9. Confirm that it is rendered and styled appropriately.

       

      Show
      Currently, there's no case to test in Moodle. Copy passwordtest.php to your moodle instance's root folder. Open passwordtest.php on your browser. Confirm that the 'Grouped password fields' are styled in the same way as the 'Standalone password field' Go to the Template library. Search for " element-password ". Click " core_form/element-password " Confirm that it is rendered and styled appropriately. Click " core_form/element-password-inline " Confirm that it is rendered and styled appropriately.  
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-68108-master

      Description

      When using a password field into a quickform and using createElement to include two password fields into a group, the style is not the same as using addElement because inline template is missing.

        Attachments

        1. afterpatch.png
          afterpatch.png
          7 kB
        2. beforepatch.png
          beforepatch.png
          8 kB
        3. image-2020-03-18-17-46-14-923.png
          image-2020-03-18-17-46-14-923.png
          53 kB
        4. image-2020-03-18-17-48-28-246.png
          image-2020-03-18-17-48-28-246.png
          15 kB
        5. image-2020-03-18-17-50-47-130.png
          image-2020-03-18-17-50-47-130.png
          16 kB
        6. passwordtest.php
          0.9 kB

          Activity

            People

            Assignee:
            pferre22 Pau Ferrer
            Reporter:
            pferre22 Pau Ferrer
            Peer reviewer:
            Noel De Martin Noel De Martin
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            Amaia Anabitarte Amaia Anabitarte
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 1 minute
                3h 1m