Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68112

The search icon container in the activity chooser search bar should use bootstrap classes

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: Course
    • Testing Instructions:
      Hide

       Testing scenario: Confirm the view hasn't visibly broken. Also confirm, accessibility has not been affected. 

      1. Create a new course
      2. Turn editing on
      3. Click on 'Add an activity or resource' link
      4. In the activity chooser, confirm the view hasn't visibly broken (especially the search text box)
      5. In the activity chooser, inspect the search text box with the browser's dev tools
      6. Confirm that the next div after the input element contains the class as follows:

        <div class='input-group-append'>

      7. Using a screen reader and with the activity chooser enabled, navigate through the chooser
      8. Confirm the screen reader announces correctly the 'search' text box
      9. Confirm on tabbing the focus goes from the search box to the tabs (if available) OR to the first activity in the list
      10. Write something (for instance, "wi") into the search text box.
      11. Confirm the search button is replaced by a cross icon.
      12. Confirm that using the tab, you can now access to this cross icon.
      13. Click the cross icon.
      14. Confirm the search text box has been emptied and the focus goes there.

       

      Show
       Testing scenario: Confirm the view hasn't visibly broken. Also confirm, accessibility has not been affected.  Create a new course Turn editing on Click on 'Add an activity or resource' link In the activity chooser,  confirm the view hasn't visibly broken (especially the search text box) In the activity chooser, inspect the search text box with the browser's dev tools Confirm that the next div after the input element contains the class as follows: <div class='input-group-append'> Using a screen reader and with the activity chooser enabled, navigate through the chooser Confirm the screen reader announces correctly the 'search' text box Confirm on tabbing the focus goes from the search box to the tabs (if available) OR to the first activity in the list Write something (for instance, "wi") into the search text box. Confirm the search button is replaced by a cross icon. Confirm that using the tab, you can now access to this cross icon. Click the cross icon. Confirm the search text box has been emptied and the focus goes there.  
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-68112-master
    • Story Points:
      1
    • Sprint:
      Activity Sprint 9, Activity Sprint 10, Activity Sprint 11

      Description

      The search icon container in the activity chooser search bar should use the existing bootstrap class ('input-group-append') instead of creating a custom alternative one.

      (https://tracker.moodle.org/browse/MDL-67263?focusedCommentId=785671&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-785671)

        Attachments

        1. MDL-68112_Step8-14.mp4
          3.53 MB
        2. MDL-68112.jpg
          MDL-68112.jpg
          40 kB
        3. searchbar-after.png
          searchbar-after.png
          17 kB
        4. searchbar-before.png
          searchbar-before.png
          16 kB

          Activity

            People

            Assignee:
            peterdias Peter Dias
            Reporter:
            Geshoski Mihail Geshoski
            Peer reviewer:
            Mihail Geshoski
            Integrator:
            Sara Arjona (@sarjona)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jun/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 hours, 10 minutes
                7h 10m