Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68142

Code to migrate the feature toggle from the plugin settings to core (tool_moodlenet master only)

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.9
    • Fix Version/s: None
    • Component/s: Other
    • Testing Instructions:
      Hide
      1. Checkout the 38 version of this patch
      2. As an adminstrator go to "Site administration > Advanced features"
      3. Scroll down to the bottom and check there is a setting to "Enable integration with MoodleNet instances" and small text underneath 'tool_moodlenet/enablemoodlenet'
      4. Disable this setting and save.
      5. Upgrade to master.
      6. After following the upgrade process you will make it to a page that shows settings that have not been set. Check that 'enablemoodlenet' is not on this list. Continue the upgrade.
      7. Go back to "Site administration > Advanced features"
      8. Check that the "Enable integration with MoodleNet instaces" is still not enabled.
      9. Check that the small text underneath the setting is now 'enablemoodlenet'
      10. Run through this test again, but leave the setting enabled. Check that the setting stays checked after upgrade.
      Show
      Checkout the 38 version of this patch As an adminstrator go to "Site administration > Advanced features" Scroll down to the bottom and check there is a setting to "Enable integration with MoodleNet instances" and small text underneath 'tool_moodlenet/enablemoodlenet' Disable this setting and save. Upgrade to master. After following the upgrade process you will make it to a page that shows settings that have not been set. Check that 'enablemoodlenet' is not on this list. Continue the upgrade. Go back to "Site administration > Advanced features" Check that the "Enable integration with MoodleNet instaces" is still not enabled. Check that the small text underneath the setting is now 'enablemoodlenet' Run through this test again, but leave the setting enabled. Check that the setting stays checked after upgrade.
    • Affected Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-68142-master
    • Story Points:
      3
    • Sprint:
      Activity Sprint 10

      Description

      This is required so that sites can upgrade from 3.7 or 3.8 to master and retain their feature toggle state.

      The way this should work is that the plugins have a version (say 2020030500) while the master plugin will be on a higher version (say 2020031000). In the master upgrade code for the tool, we want to read the tool setting and write it to the core setting.

      Acceptance criteria for this issue is as follows:

      1. 3.7 or 3.8 should be able to upgrade to master and the value of their feature toggle should carry over to the core setting in master.
      2. This should work when the toggle is true or false i.e. works regardless of state.
      3. Put a comment in version.php in the plugin to make sure it doesn't ever exceed a certain version number in master.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              abgreeve Adrian Greeve
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Peter Dias
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 1 minute
                  4h 1m