Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68144

Spacing with extended folder which has a description displayed on course site uneven

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7.5, 3.8.2
    • Fix Version/s: 3.7.6, 3.8.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Test in Classic and Boost.

      1. Insert a file to a course.
      2. Right as next resource, insert a folder with files, make sure it has a description and "Display description on course page" is checked as well as "Display folder contents" is set to "Inline on a course page".
      3. Turn off editing mode.
      4. Verify the code shows <div class="box generalbox pt-0 pb-3 foldertree"> and <div class="box generalbox pt-0 pb-3 folderbuttons"> and the margins are more narrow.

      Show
      Test in Classic and Boost. Insert a file to a course. Right as next resource, insert a folder with files, make sure it has a description and "Display description on course page" is checked as well as "Display folder contents" is set to "Inline on a course page". Turn off editing mode. Verify the code shows <div class="box generalbox pt-0 pb-3 foldertree"> and <div class="box generalbox pt-0 pb-3 folderbuttons"> and the margins are more narrow.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-68144-master

      Description

      If you display an expanded folder with description in your course the surrounding spaces are not looking right.
      As a matter of fact it seems that the description somehow belongs to the previous activity/resource and is really detached from the files contained in the folder.

      To reproduce:

      1. Insert a file to a course.
      2. Right as next resource, insert a folder with files, make sure it has a description and "Display description on course page" is checked as well as "Display folder contents" is set to "Inline on a course page"

        Attachments

        1. MDL-68144_boost-1.jpg
          MDL-68144_boost-1.jpg
          54 kB
        2. MDL-68144_classic.jpg
          MDL-68144_classic.jpg
          79 kB
        3. MDL-68144.png
          MDL-68144.png
          72 kB
        4. MDL-68144-after.png
          MDL-68144-after.png
          71 kB

          Activity

            People

            Assignee:
            lucaboesch Luca Bösch
            Reporter:
            lucaboesch Luca Bösch
            Peer reviewer:
            Bas Brands Bas Brands
            Integrator:
            Jake Dallimore Jake Dallimore
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 50 minutes
                2h 50m