Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68146

help and advanced icons are shown twice for checkboxes in forms

    XMLWordPrintable

Details

    • MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • Hide

      To verify with all branches (37, 38 and master) and both with boost and classic.

      Preparations

      1. Copy the attached checkboxes.php to the dirroot of the site.
      2. Invoke it in the browser (http://your.moodle-site/checkboxes.php).

      Verifications

      1. A form with FOUR checkboxes is displayed (nothing, help, required and help-required).
        1. The "nothing" checkbox has no icons at all.
        2. The "help" checkbox has a blue help (question) icon on the right.
          1. Hovering on it you see the "Help with format" text.
          2. Clicking on it you see a bubble starting with the text: "The course format determines the layout...."
        3. The "required" checkbox has a red required (exclamation) icon on the left.
          1. Hovering on it you see the "Required" tooltip.
        4. The "help-required" checkbox is the union of the 2 previous points (help + required). Shown in the same places and with the same bubbles and tooltips.
      2. The form also has a legend after the checkboxes with the text "There are required fields in this form marked !".
      3. The form also has a "Show more..." link. Click on it.
      4. Now the form has EIGHT checkboxes, the original four plus four new ones, all them starting with the text "advanced".
      5. The four new checkboxes are named: advanced, advanced-help, advanced-required and advanced-help-required.
        1. The "advanced" checkbox has a blue exclamation mark on the right.
          1. Hovering on it you see the "Advanced" tooltip.
        2. The "advanced-help" is the union of the advanced + help checkboxes. Icons shown in the same places and with the same tooltips and bubbles.
        3. The "advanced-required" is the union of the advanced + required checkboxes. Icons shown in the same places and with the same tooltips and bubbles.
        4. The "advanced-help-required" is the union of the advanced + help + required checkboxes. Icons shown in the same places and with the same tooltips and bubbles.
      6. The form now has a "Show less..." link. Clicking on it hides those four advanced fields.
      Show
      To verify with all branches (37, 38 and master) and both with boost and classic. Preparations Copy the attached checkboxes.php to the dirroot of the site. Invoke it in the browser ( http://your.moodle-site/checkboxes.php ). Verifications A form with FOUR checkboxes is displayed (nothing, help, required and help-required). The "nothing" checkbox has no icons at all. The "help" checkbox has a blue help (question) icon on the right. Hovering on it you see the "Help with format" text. Clicking on it you see a bubble starting with the text: "The course format determines the layout...." The "required" checkbox has a red required (exclamation) icon on the left. Hovering on it you see the "Required" tooltip. The "help-required" checkbox is the union of the 2 previous points (help + required). Shown in the same places and with the same bubbles and tooltips. The form also has a legend after the checkboxes with the text "There are required fields in this form marked !". The form also has a "Show more..." link. Click on it. Now the form has EIGHT checkboxes, the original four plus four new ones, all them starting with the text "advanced". The four new checkboxes are named: advanced, advanced-help, advanced-required and advanced-help-required. The "advanced" checkbox has a blue exclamation mark on the right. Hovering on it you see the "Advanced" tooltip. The "advanced-help" is the union of the advanced + help checkboxes. Icons shown in the same places and with the same tooltips and bubbles. The "advanced-required" is the union of the advanced + required checkboxes. Icons shown in the same places and with the same tooltips and bubbles. The "advanced-help-required" is the union of the advanced + help + required checkboxes. Icons shown in the same places and with the same tooltips and bubbles. The form now has a "Show less..." link. Clicking on it hides those four advanced fields.

    Description

      This is a regression of MDL-63424, where, together with the fix adding the required icon to checkboxes... both the help and advanced buttons were also added.

      Problem is that checkboxes show the help and advanced icons differently from the rest (on the right) and they were being already shown.

      As result, both icons are showing twice.

      (to reproduce it, just copy the attached checkboxes.php into dirroot and invoke it in the browser. All the combinations are shown there)

      This issue is about to ensure that the dupes are gone and, still, the required icon works ok.

      Attachments

        1. checkboxes_fixed.png
          34 kB
          Eloy Lafuente (stronk7)
        2. checkboxes.php
          2 kB
          Eloy Lafuente (stronk7)
        3. checkboxes.png
          34 kB
          Eloy Lafuente (stronk7)
        4. MDL-68146_Boost.jpg
          53 kB
          Anna Carissa Sadia
        5. MDL-68146_Boost (2).jpg
          53 kB
          Anna Carissa Sadia
        6. MDL-68146_Boost (3).jpg
          45 kB
          Anna Carissa Sadia
        7. MDL-68146_Classic.jpg
          52 kB
          Anna Carissa Sadia
        8. MDL-68146_Classic (2).jpg
          48 kB
          Anna Carissa Sadia
        9. MDL-68146_Classic (3).jpg
          42 kB
          Anna Carissa Sadia

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              stronk7 Eloy Lafuente (stronk7)
              Peter Dias Peter Dias
              Andrew Lyons Andrew Lyons
              Anna Carissa Sadia Anna Carissa Sadia
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/20

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 10 minutes
                  3h 10m