[MDL-68153] Trying to call qtype::get_extra_question_bank_actions must not cause fatal errors - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_38_STABLE
Fixed Branches:
MOODLE_38_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-68153~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-68153
Testing Instructions:
Hide

Install any qtype plugin from the plugins DB (e.g. https://moodle.org/plugins/qtype_oumultiresponse).
Note: If using MDK

mdk plugin install qtype_oumultiresponse

Go to a course

Create a question of that type.

Create a question of a standard type like true-false.

Delete the folder of the question type plugin. e.g. in your moodle root folder: "rm -rf question/type/oumultiresponse"

Upgrade your Moodle site "php admin/cli/upgrade"

Try to view the question bank.

Verify that the question bank shows up and you can do things with the true/false question you made.
Show
Install any qtype plugin from the plugins DB (e.g. https://moodle.org/plugins/qtype_oumultiresponse ). Note: If using MDK mdk plugin install qtype_oumultiresponse Go to a course Create a question of that type. Create a question of a standard type like true-false. Delete the folder of the question type plugin. e.g. in your moodle root folder: " rm -rf question/type/oumultiresponse " Upgrade your Moodle site " php admin/cli/upgrade " Try to view the question bank. Verify that the question bank shows up and you can do things with the true/false question you made.

To reproduce:

Expected result: question bank displays, although the questions of the missing type are useless.

Acutal result: fatal error that prevents you from seeing the question bank.

is a regression caused by

MDL-67153 Allow question types to add extra actions to the Question bank edit menu

Testing discovered

MDL-68252 Actions for rendered qtype_missingtype questions should be rendered and handled appropriately

Participants:: Anna Carissa Sadia, CiBoT, Jun Pataleta, Luca Bösch, Tim Hunt

Component watchers:: Safat Shahin, Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo

Estimated:

Not Specified

Remaining:

Logged:

2h 40m