Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68157

Implement backend enforcement upon file extension change to prevent conversion failure of the assignment submission

    XMLWordPrintable

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 3.9
    • None
    • Assignment, Filepicker
    • MOODLE_39_STABLE

    Description

      Ideally, we should implement backend logic that would prevent the conversion failure of the assignment submission. A student can upload an assignment submission file and lateer rename the file in the Filepicker. In some cases the renamed file can be without an extension (removing the file extension) or a different extension than the original which might not be supported by the document converter. This would result in failure in the conversion of the assignment submission. 

      Steps to recreate the problem:

      1. Log in as a student
      2. Submit an assignment (myassignment.docx)
      3. Click the file in the 'File submissions' panel
      4. Remove the .docx file extension from the 'Name' box (image 1)
      5. Press 'Update'
      6. Log in as a teacher
      7. Visit the assignment and press 'Grade' for the student
      8. The review panel (left) is blank 

      Some of the potential proposed solutions include checking for the file signature ('magic' number), obtaining the original extension and appending to the filename before sending it to the document converter.

      https://tracker.moodle.org/browse/MDL-60817?focusedCommentId=779827&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-779827

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Geshoski Mihail Geshoski
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: