Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68165

Update upgrade_stale_php_files_present() before 3.9 release

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: Installation
    • Labels:
    • Testing Instructions:
      Hide

      web

      1. Create/check out a 3.8.x site. For example: 

        git checkout v3.8.0

      2. Install the 3.8 site.
      3. Check out the master branch 

        git checkout master

      4. Create any of the following files that are being detected by the patch. (e.g. on Linux, use the "touch" command):
        • course/classes/output/modchooser_item.php 

          touch course/classes/output/modchooser_item.php

        • course/yui/src/modchooser/js/modchooser.js 

          course/yui/src/modchooser/js/modchooser.js

        • ...
      5. Open your Moodle instance on your browser.
      6. Log in as admin and proceed with the upgrade.
      7. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release.
      8. Delete the touched file(s) in 2.
      9. Click "Reload".
      10. Verify that the upgrade now proceeds ok.

      cli

      1. Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
      Show
      web Create/check out a 3.8.x site. For example: git checkout v3.8.0 Install the 3.8 site. Check out the master branch git checkout master Create any of the following files that are being detected by the patch. (e.g. on Linux, use the " touch " command): course/classes/output/modchooser_item.php touch course/classes/output/modchooser_item.php course/yui/src/modchooser/js/modchooser.js course/yui/src/modchooser/js/modchooser.js ... Open your Moodle instance on your browser. Log in as admin and proceed with the upgrade. Verify that a notice ("Mixed Moodle versions detected....") is displayed saying that there are problems upgrading and a proper procedure for upgrading to a major release. Delete the touched file(s) in 2. Click " Reload ". Verify that the upgrade now proceeds ok. cli Disclaimer: CLI upgrade does not run the upgrade_stale_php_files_present() check. MDL-53596 has been created about that. Nothing to test here yet.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Simply verify we have a number (4-5) of files for the next major release. They all must be files deleted since last stable version and current master

      git diff --name-status MOODLE_XX_STABLE..master | grep ^D

      Note that it's better not to pick any plugin file that maybe reinstalled manually (exception being forum files because that plugin is mandatory).

        Attachments

          Issue Links

          has a non-specific relationship to

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-66645 Update upgrade_stale_php_files_present() before 3.8 release

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Bas Brands
              Integrator:
              Jake Dallimore
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 25 minutes
                  1h 25m