Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68169

Add additional participants filter types and the ability to add multiple conditions to a filter set

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Install a new site
      2. Run the attached datagenerator (smartdata.php

      Testing

      1. Log in as admin
      2. Navigate to the CHEM102 course
      3. Open the Participants page

      Add condition limitation

      1. Press the "Add condition" button five times
        1. Confirm that you were able to do so
        2. Confirm that after pressing it five times it was disabled
      2. Delete one of the conditions
        1. Confirm that it is now re-enabled
      3. Press the "Add condition" button again
        1. Confirm that you were able to do so
        2. Confirm that after pressing it five times it was disabled
      4. Press the "Clear filters" button
        1. Confirm that all filters were removed and replaced with a single filter
        2. Confirm that you can press the Add condition button again

      Keyword filtering

      1. Select the "Keyword" option from the list of filter types
      2. Press "Add condition"
      3. Open the list of filter types in the new row
        1. Confirm that "Keyword" is not present
          Note: On IE it will be present, but disabled due to a limitation in IE
      4. Delete the extra row
      5. In the "Type or select..." section for the Keyword, search for "Ben"
      6. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that you see results with users whose first name is "Benjamin"
        3. Confirm that you see results with users whose last name is "Bennett"
      7. Choose one of the users in your list
      8. Also search for their other name. I.e. if their name is "Benjamin baker", search for "BAKER"
      9. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. *Confirm that you see results with users who match both queries
      10. Delete both search terms
      11. Note the e-mail address of one of the users
      12. Enter a unique part for the e-mail address as a search term. For example in the e-mail address "benjamin.baker@example.com.au", I can search for "min.b", or "baker@example"
      13. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that you see results with users whose e-mail address matches the term you entered
      14. Delete the Keyword search

      "Inactive for more than" filter

      1. Select the "Inactive for more than" filter
        1. Confirm that the default value of 1 day is selected
      2. Press the "Apply filters" button
        1. Confirm that the table was updated
      3. Choose a value of "3 weeks" from the list
        1. Confirm that the "1 day" option was replaced with the "3 weeks" option
      4. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that the "Last access to course" column has no values lower than 21 days in it
          Note: Users who have never logged in are not shown. This is an existing bug in the existing filtering and will be fixed in a separate issue
      5. Try with other values
        1. Confirm that onyl users who have not logged in within a longer period are shown
          Note: The "Never" option is currently not working and will be fixed when the other issue is fixed
      6. Delete the "Inactive for more than" search

      "Status" filter

      1. Select the "Status" filter
      2. Choose a value of "Inactive"
      3. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that only users who are "Suspended" are shown
      4. Delete the "Inactive" option
      5. Select to the "Active" option
      6. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that only users who are "Active" are shown
      7. Delete the "Status" search

      "Roles" filter

      1. Select the "Roles" filter
      2. Edit the roles for one of the users who is a "Student" in the course
      3. Add the "Teacher" role to that user and save
      4. Choose a value of "Teacher"
      5. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that only users who are a "Teacher" are shown
        3. Confirm tha the user who is both a student and teacher is shown
      6. Delete the "Roles" search

      "Groups" filter

      1. Select the "Groups" filter
      2. Choose one of the groups from the dropdown
      3. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that only users who are in that group are shown
      4. Delete the "Groups" search

      "Enrolment methods" filter

      1. Select the "Enrolment methods" filter
      2. Choose "Self enrolment"
        Note: Users from the script are all enrolled via Manual enrolment
      3. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that all users are removed from the search results
          Note: If you have any who are self enrolled then you will see them.
      4. Delete the "Self enrolment" filter
      5. Add "Manual enrolments" filter
      6. Press the "Apply filters" button
        1. Confirm that the table was updated
        2. Confirm that loads of results are shown
      7. Delete the "Enrolment methods" search

      Multiple filters

      1. Choose a user to play with
        Note their first name, last name, e-mail address, list of groups, and list of roles
      2. Apply a combination of Keyword, Group, Role, and last access since filters to match that user
        1. Confirm that users are removed and only users matching all properties are shown
      Show
      Setup Install a new site Run the attached datagenerator ( smartdata.php Testing Log in as admin Navigate to the CHEM102 course Open the Participants page Add condition limitation Press the "Add condition" button five times Confirm that you were able to do so Confirm that after pressing it five times it was disabled Delete one of the conditions Confirm that it is now re-enabled Press the "Add condition" button again Confirm that you were able to do so Confirm that after pressing it five times it was disabled Press the "Clear filters" button Confirm that all filters were removed and replaced with a single filter Confirm that you can press the Add condition button again Keyword filtering Select the "Keyword" option from the list of filter types Press "Add condition" Open the list of filter types in the new row Confirm that "Keyword" is not present Note: On IE it will be present, but disabled due to a limitation in IE Delete the extra row In the "Type or select..." section for the Keyword, search for " Ben " Press the "Apply filters" button Confirm that the table was updated Confirm that you see results with users whose first name is "Benjamin" Confirm that you see results with users whose last name is "Bennett" Choose one of the users in your list Also search for their other name. I.e. if their name is "Benjamin baker", search for "BAKER" Press the "Apply filters" button Confirm that the table was updated *Confirm that you see results with users who match both queries Delete both search terms Note the e-mail address of one of the users Enter a unique part for the e-mail address as a search term. For example in the e-mail address " benjamin.baker@example.com.au ", I can search for " min.b ", or " baker@example " Press the "Apply filters" button Confirm that the table was updated Confirm that you see results with users whose e-mail address matches the term you entered Delete the Keyword search "Inactive for more than" filter Select the "Inactive for more than" filter Confirm that the default value of 1 day is selected Press the "Apply filters" button Confirm that the table was updated Choose a value of "3 weeks" from the list Confirm that the "1 day" option was replaced with the "3 weeks" option Press the "Apply filters" button Confirm that the table was updated Confirm that the "Last access to course" column has no values lower than 21 days in it Note: Users who have never logged in are not shown. This is an existing bug in the existing filtering and will be fixed in a separate issue Try with other values Confirm that onyl users who have not logged in within a longer period are shown Note: The "Never" option is currently not working and will be fixed when the other issue is fixed Delete the "Inactive for more than" search "Status" filter Select the "Status" filter Choose a value of "Inactive" Press the "Apply filters" button Confirm that the table was updated Confirm that only users who are "Suspended" are shown Delete the "Inactive" option Select to the "Active" option Press the "Apply filters" button Confirm that the table was updated Confirm that only users who are "Active" are shown Delete the "Status" search "Roles" filter Select the "Roles" filter Edit the roles for one of the users who is a "Student" in the course Add the "Teacher" role to that user and save Choose a value of "Teacher" Press the "Apply filters" button Confirm that the table was updated Confirm that only users who are a "Teacher" are shown Confirm tha the user who is both a student and teacher is shown Delete the "Roles" search "Groups" filter Select the "Groups" filter Choose one of the groups from the dropdown Press the "Apply filters" button Confirm that the table was updated Confirm that only users who are in that group are shown Delete the "Groups" search "Enrolment methods" filter Select the "Enrolment methods" filter Choose "Self enrolment" Note: Users from the script are all enrolled via Manual enrolment Press the "Apply filters" button Confirm that the table was updated Confirm that all users are removed from the search results Note: If you have any who are self enrolled then you will see them. Delete the "Self enrolment" filter Add "Manual enrolments" filter Press the "Apply filters" button Confirm that the table was updated Confirm that loads of results are shown Delete the "Enrolment methods" search Multiple filters Choose a user to play with Note their first name, last name, e-mail address, list of groups, and list of roles Apply a combination of Keyword, Group, Role, and last access since filters to match that user Confirm that users are removed and only users matching all properties are shown
    • Affected Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68169-master-fixes2
    • Story Points:
      6
    • Sprint:
      International 3.9 - Sprint 9, International 3.9 - Sprint 10

      Description

      Add the Roles and Enrolment Methods enumerated filter types to the new participants filter.

      Also, enable the "+ Add condition" functionality, so that multiple filters can be added concurrently. For this issue, only AND will be applied between each filter.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              michaelh Michael Hawkins
              Peer reviewer:
              Michael Hawkins
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 days, 4 hours, 5 minutes
                  3d 4h 5m