Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68235

Incorrect section used in activity creation after section drag and drop

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.9
    • 3.9
    • Other
    • MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • Hide

      Setup:

      1 course with 4 topics

      Testing:

      1. Log in as admin
      2. Navigate to your course
      3. Turn editing on
      4. Drag topic 4 to topic 2
      5. Click the "Add activity or resource" button
      6. Add a label
      7. Confirm: you see "Adding a new label to topic 2"
      8. Add some dummy content
      9. Press "Save and return to course"
      10. Confirm: you see your new label in topic 2
      11. Now, via user prefs -> course prefs, disable the activity chooser (deselect check box and save)
      12. Go back to the course home
      13. Repeat #3-#10
        • Instead of clicking the add activity or resource button, choose the activity from the dropdown.
      14. Repeat from #2 with the course set in weekly format
      Show
      Setup: 1 course with 4 topics Testing: Log in as admin Navigate to your course Turn editing on Drag topic 4 to topic 2 Click the "Add activity or resource" button Add a label Confirm: you see "Adding a new label to topic 2" Add some dummy content Press "Save and return to course" Confirm: you see your new label in topic 2 Now, via user prefs -> course prefs, disable the activity chooser (deselect check box and save) Go back to the course home Repeat #3-#10 Instead of clicking the add activity or resource button, choose the activity from the dropdown. Repeat from #2 with the course set in weekly format
    • 1
    • Activity Sprint 11

    Description

      We now pull this from the data attribute in the link, but this isn't updated when we move a section. We used to use the value of X in id="section-X" on the section wrapper, which was being updated on drop as part of the course format drag and drop code.

      To see the problem:
      1. Pull in fix from MDL-68231 first. This fixes the section drag and drop
      2. Create 4 sections in a course - topics format is fine.
      3. Drag section 4 onto section 3
      4. Now, using section 3 add an activity

      Expected: the activity is created in section 3
      Actual: It's created in section 4.

      Attachments

        Issue Links

          Activity

            People

              mathewmay Mathew May
              jaked Jake Dallimore
              Peter Dias Peter Dias
              Víctor Déniz Falcón Víctor Déniz Falcón
              Anna Carissa Sadia Anna Carissa Sadia
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                15/Jun/20

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 1 minute
                  2d 1m