Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68239

Multimenu database field does not display the Required icon

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a mod_data instance (Database activity module).
      2. Create two fields of type multimenu, make one required, and leave the other as not required.
      3. For reference, add a field of type radiobutton and make it required
      4. Go to the "Add entry" page.
      5. Verify that there are inputs for all three fields.
      6. Verify that there are appropriate indicators near the two required fields.

       

      Show
      Create a mod_data instance (Database activity module). Create two fields of type multimenu , make one required, and leave the other as not required. For reference, add a field of type radiobutton and make it required Go to the "Add entry" page. Verify that there are inputs for all three fields. Verify that there are appropriate indicators near the two required fields.  
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull Master Branch:

      Description

      The Multimenu field type does not properly render the icon that indicates a required field.
      As the screenshots show, the icon is rendered, but it is hidden inside an accesshide tag that hides content from the visual output.

      We could replicate the behaviour of other field types that do this right, e. g., the radiobutton type.

        Attachments

        1. image-2020-04-07-12-12-01-711.png
          32 kB
          Janelle Barcega
        2. multiselect-fixed.png
          6 kB
          Jan Dageförde
        3. required-code.png
          48 kB
          Jan Dageförde
        4. required-mismatch.png
          9 kB
          Jan Dageförde

          Issue Links

            Activity

              People

              Assignee:
              n_herr03 Nina Herrmann
              Reporter:
              jan.dagefoerde Jan Dageförde
              Peer reviewer:
              Jan Dageförde Jan Dageförde
              Integrator:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 42 minutes
                  42m