Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68252

Actions for rendered qtype_missingtype questions should be rendered and handled appropriately

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      There is reasonable Behat coverage, but it would be good to also test manually:

      Setup

      1. Install any qtype plugin from the plugins DB (e.g. https://moodle.org/plugins/qtype_oumultiresponse).
        Note: If using MDK

        mdk plugin install qtype_oumultiresponse

      2. Create a test course.
      3. Go to the question bank for that course.
      4. Create a question Q1 of that installed question type.
      5. Create a question Q2 of a standard type like true-false.
      6. Delete the folder of the question type plugin. e.g. in your moodle root folder: "rm -rf question/type/oumultiresponse"
      7. Upgrade your Moodle site "php admin/cli/upgrade"

      Testing

      1. Go to the course's question bank.
      2. Open the action menu for Q1.
      3. Verify that only the Delete and Manage tags actions are shown.
      4. Choose the Manage tags action.
      5. Add a tag and click Save changes.
      6. Verify that this works with no errors, and the tag is then shown in the question list.
      7. Choose the delete action. Note you will see a debugging notice. This is expected behaviour. Please ignore it.
      8. Click delete in the confirm message. (Again, ignore the debugging notice if it appears.)
      9. Verify that the question is removed from the question list.
      10. Verify that for Q2, all 6 of the usual actions are present in the action menu.
      Show
      There is reasonable Behat coverage, but it would be good to also test manually: Setup Install any qtype plugin from the plugins DB (e.g. https://moodle.org/plugins/qtype_oumultiresponse ). Note: If using MDK mdk plugin install qtype_oumultiresponse Create a test course. Go to the question bank for that course. Create a question Q1 of that installed question type. Create a question Q2 of a standard type like true-false. Delete the folder of the question type plugin. e.g. in your moodle root folder: " rm -rf question/type/oumultiresponse " Upgrade your Moodle site " php admin/cli/upgrade " Testing Go to the course's question bank. Open the action menu for Q1. Verify that only the Delete and Manage tags actions are shown. Choose the Manage tags action. Add a tag and click Save changes. Verify that this works with no errors, and the tag is then shown in the question list. Choose the delete action. Note you will see a debugging notice. This is expected behaviour. Please ignore it. Click delete in the confirm message. (Again, ignore the debugging notice if it appears.) Verify that the question is removed from the question list. Verify that for Q2, all 6 of the usual actions are present in the action menu.
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull 3.8 Branch:
    • Pull Master Branch:

      Description

      This is an issue discovered while fixing MDL-68153. To reproduce:

      1. Install any qtype plugin from the plugins DB (e.g. https://moodle.org/plugins/qtype_oumultiresponse).
        Note: If using MDK

        mdk plugin install qtype_oumultiresponse

      2. Go to a course
      3. Create a question Q1 of that type.
      4. Create a question Q2 of a standard type like true-false.
      5. Delete the folder of the question type plugin. e.g. in your moodle root folder: "rm -rf question/type/oumultiresponse"
      6. Upgrade your Moodle site "php admin/cli/upgrade"
      7. Go to the course's question bank.
      8. Open the action menu for Q1.
      9. What happens:
        • The usual action menu items will be displayed. But clicking on these lead to coding exceptions.
      10. What should happen:
        • Only the relevant action menu item(s) should be displayed (e.g. Delete).
        • Performing an action on the "missingtype" question should lead to a successful operation and not lead to any errors.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              jpataleta Jun Pataleta
              Peer reviewer:
              Mark Johnson
              Integrator:
              Víctor Déniz Falcón
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 55 minutes
                  3h 55m