Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68256

Scheduled tasks admin: usability enhancements

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      There is some Behat coverage.

      Manual testing:

      1. Log in as admin.
      2. Navigate to Site administration > Server > System Paths
      3. Set the "Path to PHP CLI" (pathtophp) to your path to PHP
        Note: On *nix-like systems, you can find this out by typing the following into the terminal:

        which php
        

      4. Go to Administration > Server > Tasks > Scheduled tasks
      5. Verify that for each Component (e.g. Forum), the internal name (mod_forum) is also shown.
      6. Verify that you can see which components are disabled.
      7. Scroll down, and click edit on a task in the middle of the table.
      8. Change some numbers, and click Save changes.
      9. Verify that the page scrolls to the task you edited, and that table row is highlighted.
      10. Click edit on a different task.
      11. Click Cancel.
      12. Verify that the page scrolls to the task you edited (even though you did not change anything) and that table row is highlighted.
      13. Verify that on the row you edited before, the numbers you changed are now highlighted, and the default is shown.
      14. Note the fact that you cannot see the highlighted cells in the last-edited row is a Bootstrap bug (https://github.com/twbs/bootstrap/issues/29290). There is nothing we can do about this, but since this is an admin-only UI I think we can live with it.
      15. Click Run now on some task.
      16. Click Cancel.
      17. Verify the row where you clicked the Run now link is now highlighted.
      18. Click Run now on some task.
      19. Click Run now.
      20. Click Back to scheduled tasks.
      21. Verify the row for the task you jsut ran is now highlighted.
      22. If you can find a row in the table where 'Fail delay' is different from zero, click the Clear link. (If you can't find this, just stop testing now. This next bit is mostly tested be Behat anyway.)
      23. Click Cancel.
      24. Verify the row where you clicked the Clear link is now highlighted.
      25. Click the Clear link again.
      26. Click Clear.
      27. Verify the row where you clicked the Clear link is now highlighted.
      Show
      There is some Behat coverage. Manual testing: Log in as admin. Navigate to Site administration > Server > System Paths Set the "Path to PHP CLI" (pathtophp) to your path to PHP Note: On *nix-like systems, you can find this out by typing the following into the terminal: which php Go to Administration > Server > Tasks > Scheduled tasks Verify that for each Component (e.g. Forum), the internal name (mod_forum) is also shown. Verify that you can see which components are disabled. Scroll down, and click edit on a task in the middle of the table. Change some numbers, and click Save changes. Verify that the page scrolls to the task you edited, and that table row is highlighted. Click edit on a different task. Click Cancel. Verify that the page scrolls to the task you edited (even though you did not change anything) and that table row is highlighted. Verify that on the row you edited before, the numbers you changed are now highlighted, and the default is shown. Note the fact that you cannot see the highlighted cells in the last-edited row is a Bootstrap bug ( https://github.com/twbs/bootstrap/issues/29290 ). There is nothing we can do about this, but since this is an admin-only UI I think we can live with it. Click Run now on some task. Click Cancel. Verify the row where you clicked the Run now link is now highlighted. Click Run now on some task. Click Run now. Click Back to scheduled tasks. Verify the row for the task you jsut ran is now highlighted. If you can find a row in the table where 'Fail delay' is different from zero, click the Clear link. (If you can't find this, just stop testing now. This next bit is mostly tested be Behat anyway.) Click Cancel. Verify the row where you clicked the Clear link is now highlighted. Click the Clear link again. Click Clear. Verify the row where you clicked the Clear link is now highlighted.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:

      Description

      On the Administration > Server > Tasks > Scheduled tasks page, it would be useful if:

      1. There are badges to show which components are disabled.
      2. The plugin name (e.g. auth_ldap) is shown as well as the human-readable name (e.g. LDAP server).
      3. Where a time column has a non-default value, it is highlighted and the default is shown.
      4. If the fail delay is non-zero, that cell is highlighted.
      5. If you just interacted with a task (looked at or edited the settings, did Run now, or cleared the fail delay) that row is highlighted, and scrolled into view when the page loads.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Mark Johnson
              Integrator:
              Andrew Nicols
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Barbara Ramiro, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 11 minutes
                  1h 11m