Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68261

CLI changes should be included in the config changes report

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1) Go to the config log

      /report/configlog/index.php

      Visit the last page and scroll to the bottom (beginning of time) and confirm you can see the config set by user 'CLI' during initial install

      2) In the admin gui pick any config and change it

      3) Confirm this still correctly appears in the config log

      4) Set something via the cli:

      php admin/cli/cfg.php --name=debugsmtp --set=1

      Confirm this appears in the config log

      5) Repeat the same command again

      Confirm this duplicate does NOT appear in the config log

       

      Show
      1) Go to the config log /report/configlog/index.php Visit the last page and scroll to the bottom (beginning of time) and confirm you can see the config set by user 'CLI' during initial install 2) In the admin gui pick any config and change it 3) Confirm this still correctly appears in the config log 4) Set something via the cli: php admin/cli/cfg.php --name=debugsmtp --set=1 Confirm this appears in the config log 5) Repeat the same command again Confirm this duplicate does NOT appear in the config log  
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68261-cli-config-log

      Description

      Any changes made from the cli are invisible which reduces the audit-ability of the config log and erodes trust in it.

        Attachments

          Activity

            People

            Assignee:
            brendanheywood Brendan Heywood
            Reporter:
            brendanheywood Brendan Heywood
            Peer reviewer:
            Mark Nelson
            Integrator:
            Jun Pataleta
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jun/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h