[MDL-68261] CLI changes should be included in the config changes report - Moodle Tracker

XML

Word

Printable

Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
https://github.com/brendanheywood/moodle
Pull Master Branch:
~~MDL-68261~~-cli-config-log
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...brendanheywood:MDL-68261-cli-config-log
Testing Instructions:

Hide

1) Go to the config log

/report/configlog/index.php

Visit the last page and scroll to the bottom (beginning of time) and confirm you can see the config set by user 'CLI' during initial install

2) In the admin gui pick any config and change it

3) Confirm this still correctly appears in the config log

4) Set something via the cli:

php admin/cli/cfg.php --name=debugsmtp --set=1

Confirm this appears in the config log

5) Repeat the same command again

Confirm this duplicate does NOT appear in the config log

Show
1) Go to the config log /report/configlog/index.php Visit the last page and scroll to the bottom (beginning of time) and confirm you can see the config set by user 'CLI' during initial install 2) In the admin gui pick any config and change it 3) Confirm this still correctly appears in the config log 4) Set something via the cli: php admin/cli/cfg.php --name=debugsmtp --set=1 Confirm this appears in the config log 5) Repeat the same command again Confirm this duplicate does NOT appear in the config log

Any changes made from the cli are invisible which reduces the audit-ability of the config log and erodes trust in it.

Participants:: Brendan Heywood, CiBoT, Janelle Barcega, Jun Pataleta, Mark Nelson

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Estimated:

Remaining:

Logged: