[MDL-68269] Recent changes have caused some form elements to display incorrectly - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.7.6, 3.8.2, 3.9
Fix Version/s: 3.7.6, 3.8.3
Component/s: Accessibility, Forms Library
Labels:

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
git://github.com/rezaies/moodle.git
Pull Main Branch:
~~MDL-68269~~-master
Pull Main Diff URL:
https://github.com/rezaies/moodle/compare/d939d6e769...MDL-68269-master
Testing Instructions:
1. Install mod_hvp
2. go into a course and turn editing on
3. try to add ab h5p activity
4. Verify that the 'editor' field is full-width (maximum 958px)

Story Points:
1
Sprint:
International 3.9 - Sprint 9

Description

This is a regression apparently introduced by ~~MDL-67968~~

Some change into form structure/classes (fieldsets) have caused certain elements to start displaying incorrectly.

See for example https://github.com/h5p/h5p-moodle-plugin/issues/329 where the problem has been detected.

At the time of writing this it not clear which other stuff may be broken in a similar way.

Quoting tusefomal:

I see that this element fieldset goes from flex to a regular display with this change, adding a "w-100" class will increase it's compatibility with previous forms

Ciao

Attachments

Issue Links

is a regression caused by

MDL-67968 Calendar: New event: Accessibility issues

Closed

Activity

People

Assignee:: Shamim Rezaie

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: Mathew May

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: CiBoT, Eloy Lafuente (stronk7), Mathew May, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 27/Mar/20 12:32 AM

Updated:: 04/May/20 8:02 PM

Resolved:: 02/Apr/20 11:27 PM

Fix Release Date:: 11/May/20

Time Tracking

Estimated:

Remaining:

Logged:

1h 10m