Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.7.6, 3.8.3
Affects Version/s: 3.7.5, 3.8.2, 3.9
Component/s: Authentication, Unit tests
Labels:
- ci

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull Main Branch:
~~MDL-68281~~
Pull Main Diff URL:
https://github.com/stronk7/moodle/compare/MDL-68281~1...MDL-68281
Testing Instructions:
Hide

1) Init the phpunit environment

php admin/tool/phpunit/cli/init.php

2) Run the problematic testcase:

vendor/bin/phpunit --process-isolation --filter core_authlib_testcase

3) Verify that the test ends without any error.
Show
1) Init the phpunit environment php admin/tool/phpunit/cli/init.php 2) Run the problematic testcase: vendor/bin/phpunit --process-isolation --filter core_authlib_testcase 3) Verify that the test ends without any error.

Description

This is a regression introduced by ~~MDL-68183~~

In an experimental issue I've (travis windows support), where I do execute unit tests separated into multiple filtered groups... (to avoid timeouts) I'm getting the following failure:

There was 1 error:

11461) core_authlib_testcase::test_signup_validate_data_same_email

1147Error: Class 'moodle_phpmailer' not found

1149C:\Users\travis\build\stronk7\moodle\lib\tests\authlib_test.php:436

1150C:\Users\travis\build\stronk7\moodle\lib\phpunit\classes\advanced_testcase.php:80

1152To re-run:

1153 vendor/bin/phpunit --verbose "core_authlib_testcase" lib/tests/authlib_test.php

(link: https://travis-ci.org/github/stronk7/moodle/jobs/667670316)

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2020-04-01-16-14-01-109.png
51 kB
01/Apr/20 4:14 PM

Issue Links

is a regression caused by

MDL-68183 Searching for user by email (case-insensitive + accent-sensitive) is too expensive on MySQL with many users

Closed

Activity

People

Assignee:: Eloy Lafuente (stronk7)

Reporter:: Eloy Lafuente (stronk7)

Peer reviewer:: David Mudrák (@mudrd8mz)

Integrator:: Sara Arjona (@sarjona)

Tester:: Janelle Barcega

Participants:: CiBoT, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Janelle Barcega, Sara Arjona (@sarjona)

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 28/Mar/20 10:35 PM

Updated:: 02/Apr/20 11:27 PM

Resolved:: 02/Apr/20 11:27 PM

Fix Release Date:: 11/May/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 25m