Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68283

get_moodlenet_user_profile should handle validation exceptions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.9
    • Fix Version/s: None
    • Component/s: Other
    • Story Points:
      1
    • Sprint:
      Activity Sprint 10

      Description

      The user can enter in their moodlenet profile information from the user edit page which doesn't run through the same validation as the moodlenet redirect page.

      In situations where the profile information is wrong when this method is called it will throw an exception. We should catch that exception and return null. That would ask the user to enter in a moodlenet profile and the proper validation can happen here.

      Things to do:

      1. In get_moodlenet_user_profile method catch the exception and return null.
      2. Change the current exception thrown to a moodle_exception.
      3. Update the unit tests to test for an invalid username already stored.
      4. Both Master and stable plugin to be updated.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Mathew May
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 50 minutes
                  50m