[MDL-68285] Unused variables and undeclared globals in core_h5p\core - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9
Fix Version/s: 3.8.3
Component/s: H5P
Labels:

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
H5P for Moodle 3.9
Pull from Repository:
git://github.com/cescobedo/moodle.git
Pull Master Branch:
~~MDL-68285~~-master
Pull Master Diff URL:
https://github.com/cescobedo/moodle/compare/d939d6e769...MDL-68285-master
Testing Instructions:
Hide

We need to be sure that all H5P is working after this change. To do that, just we need to run all the Unit Test for h5p and Behat test with this tag @core_h5p and this testsuite core_h5p_testsuite.

Covered by unit tests (PHPUnit and Behat):

master

Behat: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/5319/

PHPUnit: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/774/

38

Behat: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/5320/

PHPUnit: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/775/
Show
We need to be sure that all H5P is working after this change. To do that, just we need to run all the Unit Test for h5p and Behat test with this tag @core_h5p and this testsuite core_h5p_testsuite. Covered by unit tests (PHPUnit and Behat): master Behat: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/5319/ PHPUnit: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/774/ 38 Behat: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/5320/ PHPUnit: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/775/

Description

Just a few I noticed in master:

$factory in get_scripts() - unused
$tempfile in fetch_content_types() - unused
$CFG in get_latest_content_types - undeclared

Attachments

Activity

People

Assignee:: Carlos Escobedo

Reporter:: Jake Dallimore

Peer reviewer:: Jake Dallimore

Integrator:: Andrew Lyons

Tester:: CiBoT

Participants:: Andrew Lyons, Carlos Escobedo, CiBoT, Jake Dallimore

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 30/Mar/20 1:18 PM

Updated:: 04/May/20 9:46 PM

Resolved:: 08/Apr/20 11:21 PM

Fix Release Date:: 11/May/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

55m