Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68298

Glossary links create duplicate popups when calling from fragments

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Development in progress
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.7.5
    • Fix Version/s: None
    • Component/s: Glossary
    • Testing Instructions:
      Hide
      1. Enable glossary filter site wide. Use the following links
        1. https://docs.moodle.org/39/en/Auto-linking
        2. https://docs.moodle.org/39/en/Glossary_auto-linking_filter
      2. Create a glossary course component make sure auto linking is enabled with the content 'Good connection Testing'
      3. Add 2 entries to the glossary with the following keywords
        1. Keyword - 'good connection'
        2. Keyword - 'testing'
      4. Confirm the glossary content is now linked to the entries created.
      5. Click on the links multiple times and confirm there is only a single popup for each item linked.
      Show
      Enable glossary filter site wide. Use the following links https://docs.moodle.org/39/en/Auto-linking https://docs.moodle.org/39/en/Glossary_auto-linking_filter Create a glossary course component make sure auto linking is enabled with the content 'Good connection Testing' Add 2 entries to the glossary with the following keywords Keyword - 'good connection' Keyword - 'testing' Confirm the glossary content is now linked to the entries created. Click on the links multiple times and confirm there is only a single popup for each item linked.
    • Affected Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-68298_master

      Description

      DESCRIPTION
      When adding glossary entries to a course the popup which is produced when clicking on the link appears in duplicate sometimes triplicate (or more) when glossary filter js is called multiple times.

      For example using course lazy loading in the Snap theme.

      STEPS TO REPLICATE
      1. Enable glossary filter site wide.
      2. Create a glossary course component make sure auto linking is enabled
      3. Add entries for glossary items found in the course.
      4. Set course theme to Snap
      5. Enable lazy load for course sections: https://www.youtube.com/watch?v=IrT6FZulDbs
      6. Click on any found glossary links in the course.

      OBSERVED BEHAVIOR:
      The popup created has multiple layers. This requires multiple clicks to clear each popup. Switch off lazy load for course sections and the issue goes away.

      EXPECTED BEHAVIOR:
      It should only be one popup.

        Attachments

          Activity

            People

            Assignee:
            dvdcastro David Castro
            Reporter:
            dvdcastro David Castro
            Peer reviewer:
            Peter Dias Peter Dias
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m