Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68315

Course form element does not respect 'onlywithcompletion' attribute.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. Make sure course completion is enabled on the site.
      2. Create 3 courses with following completion tracking settings:

      • Course 1 - completion tracking enabled
      • Course 2 - completion tracking enabled
      • Course 3 - completion tracking disabled

      3. In Course 1, navigate to "Edit" -> "Course completion", expand "Condition: Completion of other courses".
      4. Press on "Courses available" search dialog, observe that you can only see "Course 2" (but not "Course 3"
      5. Open Course 3 settings, enable completion tracking, save settings.
      6. In Course 1, navigate to "Edit" -> "Course completion", expand "Condition: Completion of other courses".
      7. Press on "Courses available" search dialog, observe that you can see "Course 2" and "Course 3".

      Show
      1. Make sure course completion is enabled on the site. 2. Create 3 courses with following completion tracking settings: Course 1 - completion tracking enabled Course 2 - completion tracking enabled Course 3 - completion tracking disabled 3. In Course 1, navigate to "Edit" -> "Course completion", expand "Condition: Completion of other courses". 4. Press on "Courses available" search dialog, observe that you can only see "Course 2" (but not "Course 3" 5. Open Course 3 settings, enable completion tracking, save settings. 6. In Course 1, navigate to "Edit" -> "Course completion", expand "Condition: Completion of other courses". 7. Press on "Courses available" search dialog, observe that you can see "Course 2" and "Course 3".
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE
    • Pull 3.7 Branch:
      MDL-68315-MOODLE_37_STABLE
    • Pull 3.8 Branch:
      MDL-68315-MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-68315-master

      Description

      Passing `onlywithcompletion` attribute does not seem limiting the list to only courses with completion enabled.

      This happens for example when add a course completion condition "completion of other courses" or when add a "completion course set" criteria to a badge.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              kabalin Ruslan Kabalin
              Reporter:
              kabalin Ruslan Kabalin
              Peer reviewer:
              Ferran Recio
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours
                  6h