[MDL-68315] Course form element does not respect 'onlywithcompletion' attribute. - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.5, 3.8.2, 3.9
Fix Version/s: 3.7.6, 3.8.3
Component/s: Forms Library
Labels:
- affects_workplace
- ci
- patch
- triaged

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/kabalin/moodle.git
Pull Master Branch:
~~MDL-68315~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...kabalin:MDL-68315-master
Testing Instructions:
Hide

1. Make sure course completion is enabled on the site.
2. Create 3 courses with following completion tracking settings:

Course 1 - completion tracking enabled

Course 2 - completion tracking enabled

Course 3 - completion tracking disabled

3. In Course 1, navigate to "Edit" -> "Course completion", expand "Condition: Completion of other courses".
4. Press on "Courses available" search dialog, observe that you can only see "Course 2" (but not "Course 3"
5. Open Course 3 settings, enable completion tracking, save settings.
6. In Course 1, navigate to "Edit" -> "Course completion", expand "Condition: Completion of other courses".
7. Press on "Courses available" search dialog, observe that you can see "Course 2" and "Course 3".
Show
1. Make sure course completion is enabled on the site. 2. Create 3 courses with following completion tracking settings: Course 1 - completion tracking enabled Course 2 - completion tracking enabled Course 3 - completion tracking disabled 3. In Course 1, navigate to "Edit" -> "Course completion", expand "Condition: Completion of other courses". 4. Press on "Courses available" search dialog, observe that you can only see "Course 2" (but not "Course 3" 5. Open Course 3 settings, enable completion tracking, save settings. 6. In Course 1, navigate to "Edit" -> "Course completion", expand "Condition: Completion of other courses". 7. Press on "Courses available" search dialog, observe that you can see "Course 2" and "Course 3".

Description

Passing `onlywithcompletion` attribute does not seem limiting the list to only courses with completion enabled.

This happens for example when add a course completion condition "completion of other courses" or when add a "completion course set" criteria to a badge.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-68315.jpg
19 kB
04/May/20 5:42 PM

Issue Links

will help resolve

MDL-68327 Badge criteria "Completing a set of courses" allows to select courses that has completion tracking disabled

Open

MDL-68325 'Complete another course' allows to select courses that has completion tracking disabled

Closed

Activity

People

Assignee:: Ruslan Kabalin

Reporter:: Ruslan Kabalin

Peer reviewer:: Ferran Recio

Integrator:: Sara Arjona (@sarjona)

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Ferran Recio, Ruslan Kabalin, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 02/Apr/20 6:57 AM

Updated:: 06/May/20 1:45 AM

Resolved:: 06/May/20 1:45 AM

Fix Release Date:: 11/May/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: