Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68329

Improve the cache performance footer info even more

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1) /cache/admin.php Setup some cache stores, including some primary / secondary caches, eg localizable caches like course mod info

      2) Turn on the perfdebug

      3) Clear caches, look at the footer info and confirm everything lines up and looks good. 

      4) Confirm that the individual primary / secondary cache stores re visible rather than the cache store class name. NOTE: only cache stores that get a read will be shown, so a second / final store may not be shown if there was no misses on the primary cache.

      5) Confirm how it is now visible that cache misses on a higher cache (eg static) flow down to the primary and then secondary etc cache stores

      Show
      1) /cache/admin.php Setup some cache stores, including some primary / secondary caches, eg localizable caches like course mod info 2) Turn on the perfdebug 3) Clear caches, look at the footer info and confirm everything lines up and looks good.  4) Confirm that the individual primary / secondary cache stores re visible rather than the cache store class name. NOTE: only cache stores that get a read will be shown, so a second / final store may not be shown if there was no misses on the primary cache. 5) Confirm how it is now visible that cache misses on a higher cache (eg static) flow down to the primary and then secondary etc cache stores
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68329-cache-info

      Description

      There are a few keys bit of info I want to see:

      1) Each cache def shows that cache store plugins where used, but I want to see what cache store instances were used. ie you might have 2 file caches or 2 redis caches.

      2) We get mini totals for each cache def, and a total for the lot, but we don't get a breakdown for each instance which is what I really want to see. For instance on this page there are 134 cache misses which looks like an issue to address, but they are all static cache misses so that's just fine.

      Also I think the display formatting could do with some love, it's fairly hard to parse quickly

       

        Attachments

        1. good_enough.png
          good_enough.png
          183 kB
        2. good_enough-1.png
          good_enough-1.png
          183 kB
        3. image-2020-04-03-13-47-52-259.png
          image-2020-04-03-13-47-52-259.png
          35 kB
        4. image-2020-04-07-22-57-26-364.png
          image-2020-04-07-22-57-26-364.png
          109 kB
        5. image-2020-04-15-13-42-49-800.png
          image-2020-04-15-13-42-49-800.png
          39 kB
        6. image-2020-04-28-09-29-30-145.png
          image-2020-04-28-09-29-30-145.png
          26 kB
        7. image-2020-04-29-17-24-25-633.png
          image-2020-04-29-17-24-25-633.png
          110 kB
        8. image-2020-04-29-17-28-51-867.png
          image-2020-04-29-17-28-51-867.png
          1.10 MB
        9. image-2020-04-29-22-21-44-668.png
          image-2020-04-29-22-21-44-668.png
          48 kB
        10. image-2020-04-29-22-21-52-189.png
          image-2020-04-29-22-21-52-189.png
          73 kB
        11. image-2020-04-30-00-31-34-619.png
          image-2020-04-30-00-31-34-619.png
          33 kB
        12. Screenshot 2020-04-29 at 17.08.13.png
          Screenshot 2020-04-29 at 17.08.13.png
          1.10 MB
        13. too_many_stores.png
          too_many_stores.png
          123 kB
        14. what_does_this_say.png
          what_does_this_say.png
          126 kB
        15. with_three_stores.png
          with_three_stores.png
          196 kB

          Issue Links

            Activity

              People

              Assignee:
              brendanheywood Brendan Heywood
              Reporter:
              brendanheywood Brendan Heywood
              Peer reviewer:
              Peter Burnett
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              2 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 11 minutes
                  5h 11m