[MDL-68339] Invalid array operations on objects recently introduced - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

It should be enough to rely on automated testing to consider this passed:

Normal ci.moodle.org behat runs should continue passing.

Specific php74 behat runs should be now green: https://ci.moodle.org/view/Testing/job/DEV.74%20-%20Behat%20(chrome)%207.4%20-%20MDL-66260/69/

That's all!
Show
It should be enough to rely on automated testing to consider this passed: Normal ci.moodle.org behat runs should continue passing. Specific php74 behat runs should be now green: https://ci.moodle.org/view/Testing/job/DEV.74%20-%20Behat%20(chrome)%207.4%20-%20MDL-66260/69/ That's all!
Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Epic Link:
Prepare Moodle for PHP 7.4
Pull from Repository:
https://github.com/stronk7/moodle.git
Pull 3.8 Branch:
~~MDL-68339~~_38
Pull 3.8 Diff URL:
https://github.com/stronk7/moodle/compare/MDL-68339_38~1...MDL-68339_38
Pull Master Branch:
~~MDL-68339~~
Pull Master Diff URL:
https://github.com/stronk7/moodle/compare/MDL-68339~1...MDL-68339

After ~~MDL-66968~~ and ~~MDL-67049~~... one more case, recently introduced by ~~MDL-65620~~ has been detected.

array_key_exists(): Using array_key_exists() on objects is deprecated. Use isset() or property_exists() instead

This is, simply, about to change that incorrect use and verify that there aren't more behat failures caused by that deprecation notice.

Ciao

blocks

MDL-66263 Bump Travis max version to 7.4

is a regression caused by

MDL-65620 Default notification preferences are unset by default

Participants:: Carlos Escobedo, CiBoT, Eloy Lafuente (stronk7), Jun Pataleta

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)

Estimated:

Remaining:

Logged:

1h 30m