Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68351

Backport MDL-67374 (Upgrade SimplePie to latest version) to 38_STABLE

XMLWordPrintable

    • MOODLE_38_STABLE
    • MOODLE_38_STABLE
    • Hide

      From original issue:

      Useful feed for these tests:

      http://feeds.bbci.co.uk/news/technology/rss.xml

      1. Create an external blog.
        1. Go to the user menu (top right hand corner) and select 'preferences'.
        2. Click on 'External blogs' (Blogs).
        3. Click 'Register an external blog'
        4. Find an rss feed from somewhere and fill in the details.
      2. View the blog by changing the URL to [MOODLE_URL]/blog
        1. Confirm that you can see items in the feed
      3. Go back to the list of feeds (previous page)
        1. Confirm that you can edit and delete the feeds.
      4. Create an rss feed via the remote rss feeds block
        1. Find a course and add the "remote rss feeds" block.
        2. Configure the block
        3. Add an external feed (find a working rss feed).
        4. In the block settings choose the feed that you added
        5. Save changes
      5. View your Dashboard
        1. Confirm that you can see items in the feed
      6. Edit the block settings
      7. Edit the feeds
        1. Confirm that you can edit and delete the feeds.

      For php74

      1. Verify that the php74_38 branch is passing unit-tests (that branch does include this issue and others in the php74 epic, it's built automatically):
        1. In travis: https://travis-ci.org/github/stronk7/moodle/builds/671700544
        2. In ci.moodle.org: https://ci.moodle.org/view/Testing/job/DEV.74%20-%20PHPUnit%207.4%20-%20MDL-66260/85/
      Show
      From original issue: Useful feed for these tests: http://feeds.bbci.co.uk/news/technology/rss.xml Create an external blog. Go to the user menu (top right hand corner) and select 'preferences'. Click on 'External blogs' (Blogs). Click 'Register an external blog' Find an rss feed from somewhere and fill in the details. View the blog by changing the URL to [MOODLE_URL] /blog Confirm that you can see items in the feed Go back to the list of feeds (previous page) Confirm that you can edit and delete the feeds. Create an rss feed via the remote rss feeds block Find a course and add the "remote rss feeds" block. Configure the block Add an external feed (find a working rss feed). In the block settings choose the feed that you added Save changes View your Dashboard Confirm that you can see items in the feed Edit the block settings Edit the feeds Confirm that you can edit and delete the feeds. For php74 Verify that the php74_38 branch is passing unit-tests (that branch does include this issue and others in the php74 epic , it's built automatically): In travis: https://travis-ci.org/github/stronk7/moodle/builds/671700544 In ci.moodle.org: https://ci.moodle.org/view/Testing/job/DEV.74%20-%20PHPUnit%207.4%20-%20MDL-66260/85/

      MDL-67374 updated SimplePie from 1.5.2 --> 1.5.3.

      Changes were really small (mostly is was text) and it comes with a php74 support change that we need in the 38_STABLE branch.

      While the change could be picked individually, in this case it seems that picking the whole issue is safe and better (so we don't have to keep local modifications).

      So this is a proposal to backport, plain and straight, the original issue.

        1. MDL-68351 (2).jpg
          MDL-68351 (2).jpg
          35 kB
        2. MDL-68351.jpg
          MDL-68351.jpg
          60 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Tim Hunt Tim Hunt
            Jun Pataleta Jun Pataleta
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 5 minutes
                3h 5m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.