Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68356

H5P icon incorrectly being associated with IMSCC backups

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8.2, 3.9
    • Fix Version/s: 3.8.3
    • Component/s: H5P
    • Testing Instructions:
      Hide

      Before applying the patch apply the following steps

      1. You need a clean site moodle installation without the patch.
      2. Login as an admin.
      3. Go to Private files.
      4. Upload the h5p files attached in the issue, chart.h5p and drag-and-drop.h5p.
      5. Click in Saves changes.
      6. Expected result: Confirm you could see the chat.h5p and drag-and-drop.h5p files with the h5p icon.
      7. Now, create a course empty named C1.
      8. Go to course C1 and do the backup, making sure to check/enable the 'IMS Common Cartridge 1.1' option (we don't want files because of the bug reported in MDL-67870).
      9. Once complete, click "Manage backups".
      10. In recent items, see the backup of the course and the h5p files.
      11. Expected result: Confirm you see the H5P icon for the backup of the course. You should see:

      After applying the patch

      Testing scenario 1: Check the IMSCP backups show the right icon.

      1. Login as an admin.
      2. Upgrade the site.
      3. Go to course C1 and click on Restore action.
      4. Click "Manage backups".
      5. In recent items, see the backup of the course and the h5p files.
      6. Expected result: Confirm you don't see the H5P icon for the backup of the course and you should see this:

      Testing scenario 2: Check upgrade Database existing files.

      1. Expected result: Confirm the 'files' table in the Database that the two h5p files have  'application/zip.h5p' mimetype.

       

      Show
      Before applying the patch apply the following steps You need a clean site moodle installation without the patch. Login as an admin. Go to Private files. Upload the h5p files attached in the issue, chart.h5p and drag-and-drop.h5p. Click in Saves changes. Expected result: Confirm you could see the chat.h5p and drag-and-drop.h5p files with the h5p icon. Now, create a course empty named C1. Go to course C1 and do the backup, making sure to check/enable the 'IMS Common Cartridge 1.1' option (we don't want files because of the bug reported in  MDL-67870 ). Once complete, click "Manage backups". In recent items, see the backup of the course and the h5p files. Expected result: Confirm  you see the H5P icon for the backup of the course. You should see: After applying the patch Testing scenario 1: Check the IMSCP backups show the right icon. Login as an admin. Upgrade the site. Go to course C1 and click on Restore action. Click "Manage backups". In recent items, see the backup of the course and the h5p files. Expected result: Confirm  you don't see the H5P icon for the backup of the course and you should see this: Testing scenario 2: Check upgrade Database existing files. Expected result: Confirm the 'files' table in the Database that the two h5p files have  'application/zip.h5p' mimetype.  
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-68356-master

      Description

      This one is pretty easy to see in action:
      1. Backup an empty course, making sure to check/enable the IMSCC option (we don't want files because of the bug reported in MDL-67870)
      2. Once complete, click "Manage backups"
      3. In recent items, see the backup.imscc
      Expected: it has a non-H5P icon
      Actual: It has an H5P icon like this:

        Attachments

        1. chart.h5p
          107 kB
        2. drag-and-drop.h5p
          994 kB
        3. h5p_backups_icon.jpg
          h5p_backups_icon.jpg
          23 kB
        4. image-2020-04-07-15-50-26-165.png
          image-2020-04-07-15-50-26-165.png
          36 kB
        5. MDL-68356_AfterPatch.jpg
          MDL-68356_AfterPatch.jpg
          36 kB
        6. MDL-68356_BeforePatch.jpg
          MDL-68356_BeforePatch.jpg
          37 kB
        7. Screenshot 2020-04-07 at 15.47.07.png
          Screenshot 2020-04-07 at 15.47.07.png
          42 kB

          Issue Links

            Activity

              People

              Assignee:
              cescobedo Carlos Escobedo
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Amaia Anabitarte
              Integrator:
              Jun Pataleta
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 7 hours, 10 minutes
                  7h 10m